filtering for iframes not working for c62 #11621

bbondy · 2017-10-22T01:22:02Z

Because we are skipping if tabId is -1 in app/filtering.js

STR:

launch brave and load https://coinmarketcap.com/
wait ~10s and you should see an ad being displayed on the bottom right of the page

Example:

This is not on C61 builds.


        Fix filtering not knowing tabId

Fix brave/browser-laptop#11621


        Fix filtering not knowing tabId

Fix brave/browser-laptop#11621 See also: https://chromium.googlesource.com/chromium/src/+/1b8747c4fed55e7fde4344eb0a71463855096502%5E%21/


        Fix filtering not knowing tabId

Fix brave/browser-laptop#11621 See also: https://chromium.googlesource.com/chromium/src/+/1b8747c4fed55e7fde4344eb0a71463855096502%5E%21/


        Fix filtering not knowing tabId

Fix brave/browser-laptop#11621 See also: https://chromium.googlesource.com/chromium/src/+/1b8747c4fed55e7fde4344eb0a71463855096502%5E%21/


        Fix filtering not knowing tabId

Fix brave/browser-laptop#11621 See also: https://chromium.googlesource.com/chromium/src/+/1b8747c4fed55e7fde4344eb0a71463855096502%5E%21/


        Fix filtering not knowing tabId

Fix brave/browser-laptop#11621 See also: https://chromium.googlesource.com/chromium/src/+/1b8747c4fed55e7fde4344eb0a71463855096502%5E%21/

bbondy · 2017-10-24T15:52:35Z

master: 81b7b7f
0.21.x: d3e9270
0.20.x: 83928ac
0.19.x: 4eb31ea

bbondy added this to the 0.19.x Hotfix 2 (Release channel) milestone Oct 22, 2017

luixxiul added the cr62 label Oct 22, 2017

bbondy added regression release-notes/exclude labels Oct 22, 2017

bbondy self-assigned this Oct 22, 2017

bbondy added the QA/test-plan-specified label Oct 22, 2017

bbondy added a commit to brave/muon that referenced this issue Oct 23, 2017

Fix filtering not knowing tabId

Verified

This commit was signed with a verified signature.

bbondy Brian R. Bondy

GPG key ID: C063402E6BCBEFAD Learn about signing commits

95f9cc8

Fix brave/browser-laptop#11621

bbondy mentioned this issue Oct 23, 2017

Fix filtering not knowing tabId #352

Merged

bbondy mentioned this issue Oct 23, 2017

Youtube ads shown after upgrade to chromium 62 #11619

Closed

bridiver closed this in brave/muon#352 Oct 23, 2017

srirambv added the QA/checked-Win64 label Oct 25, 2017

LaurenWags added the QA/checked-macOS label Oct 25, 2017

luixxiul added the QA/checked-Linux label Oct 25, 2017

LaurenWags mentioned this issue Oct 26, 2017

Manual test run on Windows ia-32 for 0.19.x Hotfix 2 (Release channel) #11680

Closed

0 of 118 tasks complete

brave / browser-laptop Archived

filtering for iframes not working for c62 #11621

filtering for iframes not working for c62 #11621

bbondy commented Oct 22, 2017 •

edited by kjozwiak

bbondy commented Oct 24, 2017

brave / browser-laptop Archived

Join GitHub today

filtering for iframes not working for c62 #11621

filtering for iframes not working for c62 #11621

Comments

bbondy commented Oct 22, 2017 • edited by kjozwiak

bbondy commented Oct 24, 2017

bbondy commented Oct 22, 2017 •

edited by kjozwiak