Skip to content
This repository has been archived by the owner. It is now read-only.

/ browser-laptop Archived

Reduce the size of the ad manifest #11732

Closed
bbondy opened this issue Oct 31, 2017 · 1 comment
Closed

Reduce the size of the ad manifest #11732

bbondy opened this issue Oct 31, 2017 · 1 comment
Assignees
@bbondy
Labels
QA/no-qa-needed release-notes/exclude
Milestone
0.19.x Hotfix 3 (...

Comments

@bbondy
Copy link
Member

@bbondy bbondy commented Oct 31, 2017

Since we're only using placeholders this task is to zero out the ad manifest.
The file is over 1MB and gets injected via content script in each load.
@bbondy bbondy self-assigned this Oct 31, 2017
bbondy added a commit that referenced this issue Oct 31, 2017
@bbondy
Zero out ad manifest
Verified
This commit was signed with a verified signature.
bbondy Brian R. Bondy
GPG key ID: C063402E6BCBEFAD Learn about signing commits
Loading status checks…
33aa654 
Auditors: @bsclifton

Fix #11732
bbondy added a commit that referenced this issue Oct 31, 2017
@bbondy
Zero out ad manifest
Verified
This commit was signed with a verified signature.
bbondy Brian R. Bondy
GPG key ID: C063402E6BCBEFAD Learn about signing commits
Loading status checks…
088a2b2 
Auditors: @bsclifton

Fix #11732
bbondy added a commit that referenced this issue Oct 31, 2017
@bbondy
Zero out ad manifest
Verified
This commit was signed with a verified signature.
bbondy Brian R. Bondy
GPG key ID: C063402E6BCBEFAD Learn about signing commits
Loading status checks…
12e8c2e 
Auditors: @bsclifton

Fix #11732
@bbondy bbondy closed this in 2d3fd8f Oct 31, 2017
@bbondy
Copy link
Member Author

@bbondy bbondy commented Oct 31, 2017

master: 2d3fd8f
0.21.x: 12e8c2e
0.20.x: 088a2b2
0.19.x: 33aa654
syuan100 added a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@bbondy @syuan100
Zero out ad manifest
3beb18f 
Auditors: @bsclifton

Fix brave#11732
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbondy bbondy

Labels
QA/no-qa-needed release-notes/exclude
Projects
None yet
Milestone
  0.19.x Hotfix 3 (...
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@bbondy @luixxiul
You can’t perform that action at this time.