Skip to content
This repository has been archived by the owner. It is now read-only.

sync V2: Add remove function for any single device in sync chain #12356

Closed
bradleyrichter opened this issue Dec 21, 2017 · 1 comment
Closed

sync V2: Add remove function for any single device in sync chain #12356

bradleyrichter opened this issue Dec 21, 2017 · 1 comment

Comments

@bradleyrichter
Copy link
Contributor

@bradleyrichter bradleyrichter commented Dec 21, 2017

As a user, I need to be able to remove a device from my device list in the case that that device was lost or otherwise no longer accessible to me.

Feature:
Any device in the sync chain will have the ability to remove any other device. When a device is removed, a new file is posted to the server and the previous data file is deleted. The new data file holds a record of the deleted device.

See desktop UI:
image

Approach:
This record is read by other devices in the sync chain so that they can update the status of the deleted device in their local lists.

If the device itself has been deleted from the chain, it will read it's own deletion file and display a dialog. "The sync chain is no longer available to this device."

Dialogs:
If the active device (this computer) is removed, a warning dialog will appear explaining the result.

image

If a different device is removed, a different warning dialog appears to confirm the result.

image

Notes:
If the active device is removed, the UI will reset to the first-time-use wizard.

The delete button from the ledger UI control should be used in this device list.

The device list styles should match other list controls.

@bradleyrichter bradleyrichter added this to the 0.21.x (Developer Channel) milestone Dec 21, 2017
@NejcZdovc NejcZdovc removed their assignment Jan 12, 2018
@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Beta Channel), 0.22.x (Developer Channel) Feb 20, 2018
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
cezaraugusto pushed a commit that referenced this issue Mar 1, 2018
Cezar Augusto
fix #9254
fix #12356
cezaraugusto pushed a commit that referenced this issue Mar 2, 2018
Cezar Augusto
fix #9254
fix #12356
cezaraugusto pushed a commit that referenced this issue Mar 16, 2018
Cezar Augusto
fix #9254
fix #12356
cezaraugusto pushed a commit that referenced this issue Mar 21, 2018
Cezar Augusto
fix #9254
fix #12356
cezaraugusto pushed a commit that referenced this issue Apr 2, 2018
Cezar Augusto
fix #9254
fix #12356
cezaraugusto pushed a commit that referenced this issue Apr 4, 2018
Cezar Augusto
fix #9254
fix #12356
@cezaraugusto cezaraugusto mentioned this issue Apr 4, 2018
cezaraugusto added a commit that referenced this issue Apr 9, 2018
fix #9254
fix #12356
cezaraugusto added a commit that referenced this issue Apr 10, 2018
fix #9254
fix #12356
cezaraugusto added a commit that referenced this issue Apr 27, 2018
fix #9254
fix #12356
@bsclifton bsclifton modified the milestones: 0.23.x (Developer Channel), 0.24.x (Nightly Channel) May 1, 2018
@bsclifton bsclifton removed this from the 0.24.x (Developer Channel) milestone Jun 18, 2018
@bsclifton
Copy link
Member

@bsclifton bsclifton commented Jun 18, 2018

Closing as wontfix since we're going to switch gears and focus more on Brave Core. This is captured there with brave/brave-browser#356

@bsclifton bsclifton closed this Jun 18, 2018
@bsclifton bsclifton added the wontfix label Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.