Skip to content
This repository has been archived by the owner. It is now read-only.

New tab should not be black if you disable "show backgrounds" #12380

Closed
Jacalz opened this issue Dec 22, 2017 · 9 comments

Comments

@Jacalz
Copy link
Collaborator

commented Dec 22, 2017

Description

A time ago the new tab color changed to being black. It does look very good with backgrounds on the new tab but it does look terrible when you turn off the backgrounds:
image

Steps to Reproduce

  1. Go to about:preferences/tabs
  2. Turn off "show images"
  3. Open a new tab with the dasboard

Actual result:

The tab is black and it just looks strange like the color chooser missed something, look at the above picture!

Expected result:
Should have the same color as the pixels beneath the tab.

Reproduces how often:

100%

Brave Version

about:brave info:

Brave: 0.19.120
rev: 028351e
Muon: 4.5.30
libchromiumcontent: 63.0.3239.108
V8: 6.3.292.48
Node.js: 7.9.0
Update Channel: Release
OS Platform: Microsoft Windows
OS Release: 10.0.16299
OS Architecture: x64

Reproducible on current live release:

Yes

Additional Information

@Jacalz Jacalz changed the title Black new tab should not be black when you don´t have backgrounds on New tab should not be black if you disable "show backgrounds" Dec 22, 2017
@modusops

This comment has been minimized.

Copy link

commented Jan 1, 2018

Seems to be ok for macOS.

No issues with turning off and opening a new tab. BG is the default grey.

Brave: 0.19.123
rev: f45cb3a
Muon: 4.5.31
libchromiumcontent: 63.0.3239.108
V8: 6.3.292.48
Node.js: 7.9.0
Update Channel: Release
OS Platform: macOS
OS Release: 17.3.0
OS Architecture: x64

@MargarytaChepiga

This comment has been minimized.

Copy link
Collaborator

commented Mar 9, 2018

It is still reproducible on windows.

@MargarytaChepiga

This comment has been minimized.

Copy link
Collaborator

commented Mar 9, 2018

Do we want to change it though? It looks really great when the background is on. Or should we change the tab color to be grey when the background is off and leave if black when it is on?

@Jacalz

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 9, 2018

This should be changed in my opinion in order for it to look better but ONLY for when backgrounds are turned off 🙂

@bsclifton bsclifton added this to the Triage Backlog milestone Mar 10, 2018
@MargarytaChepiga

This comment has been minimized.

Copy link
Collaborator

commented Mar 12, 2018

@Jacalz Oh okay, sorry I misunderstood you 😄

@Jacalz Jacalz removed the suggestion label Mar 22, 2018
@Jacalz

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 22, 2018

There are two ways this could be fixed:

  1. A black gradient/shadow could be added to make it transition to black from that "no background" page. It would look pretty much like what is done when you have backgrounds enabled.

  2. The tab color could be chnaged to what is under it but that would mean that the tab color would need to change relative to where it is situated in the tab row. The first option is probably the most useful one though.

@Jacalz

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 22, 2018

I have tested on Windows, MacOS and also on Linux (Solus to be more specific) and all platforms have the same issue.

@bsclifton bsclifton modified the milestones: Triage Backlog, Backlog (Prioritized) Mar 23, 2018
@Jacalz

This comment has been minimized.

Copy link
Collaborator Author

commented Mar 24, 2018

I sat down with gimp an created a little mockup on how it could look when fixed:
newtab-mockup

@MargarytaChepiga

This comment has been minimized.

Copy link
Collaborator

commented Apr 5, 2018

@Jacalz I am looking at this right now, and I was able to do this:
variant 1
I can do with different variations of having more/less of any of the colors. However, I couldn't figure out a way yet of how we can have a radiant-gradient for the whole page and only on the top to have a linear black.

@bsclifton bsclifton added the stale label Sep 3, 2018
@bsclifton bsclifton closed this Sep 3, 2018
@bsclifton bsclifton removed this from the Backlog (Prioritized) milestone Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.