Pressing Alt+F doesn't open file menu

[srirambv]

Description

Pressing Alt+F doesn't open file menu

Steps to Reproduce

1. Set browser focus
2. Hide file menu by default
3. Press Alt+F, file menu is not shown.

Actual result:
Pressing Alt+F combination should open up file menu

Expected result:

Reproduces how often:
100%

Brave Version

about:brave info:

Brave	0.20.14
Brave Sync	v1.4.2
libchromiumcontent	63.0.3239.108
Muon	4.5.33
Node.js	7.9.0
OS Architecture	x64
OS Platform	Microsoft Windows
OS Release	10.0.16299
rev	5d75826
Update Channel	Beta
V8	6.3.292.48

Reproducible on current live release:
Yes

Additional Information

[bsclifton]

Because the Windows version of the app does not use a standard menu, this will not be a trivial change ☹️

[hugobuddel]

Alt-F (or just Alt) does not open the menu either on 0.19.134 in Linux either.

[bsclifton]

@hugobuddel thanks for calling that out. I believe the menu on Linux is implemented via the Electron popup control. This must not be setting accelerators

[jayyyin]

@bsclifton do you know where the code is for this? I'd like to see if I can take a stab at this.
I think I found the code to handle the key presses here

browser-laptop/app/renderer/components/main/main.js

Lines 176 to 179 in bcec3be

	// For ALT menu processing
	if (Object.keys(this.keydown).length > 1) {
	this.keydownHistory.push(e.which)
	} else {

but I'm not sure what the command for opening "file" menu would be

[jayyyin]

@bsclifton so if I'm understanding this correctly, I need to add a new WindowAction to tell the selection to update, to do that I need a new windowStore and to do that I need a new WindowConstant, am I understanding this right?

[jayyyin]

I've opened a second pull request since my first branch kind of broke and I wanted to keep it for reference since I did get somewhere with it, so I made a new branch for my second attempt at this, I'm really close I just need some feedback for how to approach actually making the submenu show up after it's been selected, any help would be appreciated.

[MargarytaChepiga]

I just checked it on Win10, just ALT works perfectly.
Nevermind, checked the wrong thing. Still reproducible.

[jayyyin]

I managed to get the submenu to show up after pressing alt-f twice or pressing and holding it with @MargarytaChepiga's help, currently working to get it on single (non-held) press

[bsclifton]

Closing this issue as a duplicate of #2949