Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Extension: Reddit Enhancement Suite (RES) #12858

Closed
6 of 27 tasks
jonathansampson opened this issue Jan 26, 2018 · 2 comments
Closed
6 of 27 tasks

Extension: Reddit Enhancement Suite (RES) #12858

jonathansampson opened this issue Jan 26, 2018 · 2 comments
Labels
feature/extensions fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. wontfix

Comments

@jonathansampson
Copy link
Collaborator

jonathansampson commented Jan 26, 2018

Extension: Reddit Enhancement Suite

image

Needed APIs:

chrome.downloads

chrome.extension

chrome.history

chrome.pageAction

This requires insight and direction from the design team.

chrome.permissions

chrome.runtime

chrome.storage

chrome.tabs

chrome.webRequest

chrome.windows

@jonathansampson
Copy link
Collaborator Author

Some cursory testing of this extensions reveals a few obvious issues, though they may be minor in the grand scheme of things. The pageAction.{show, setIcon, setTitle} methods are not supported. Likewise, the history.addUrl method is unavailable to the extension. These are the biggest omissions in my 10-15 minutes of testing.

The absence of these methods don't appear to cripple the experience; we may be able to ship support before these are fully implemented. As noted above, pageAction will require guidance from the design team, as this requires a new UI element.

@bsclifton bsclifton added wontfix fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. labels Aug 24, 2018
@bsclifton
Copy link
Member

When we move to brave-core (which is just around the corner), we should have full support for extensions. Stay tuned 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/extensions fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. wontfix
Projects
None yet
Development

No branches or pull requests

2 participants