Skip to content
This repository has been archived by the owner. It is now read-only.

AltGr + Number opens up a new session tab #12956

Closed
rasved opened this Issue Jan 31, 2018 · 21 comments

Comments

@rasved
Copy link

rasved commented Jan 31, 2018

Test plan

#13042 (comment)


The shortcut for New Tab is the same as @ (at-sign) on Nordic keyboards. That's pretty annoying when typing in email addresses in web forms...
Just realized that when I type square brackets (as in the subject) I open new tabs as well...
So the result after this posting is 4 new tabs... 🐛

I can't find anywhere I can change it myself.
Are this option missing in the menues, or do I oversee something?

Thanks in advance,
Rasmus

@sepeiFH

This comment has been minimized.

Copy link

sepeiFH commented Jan 31, 2018

+1 very annoying. Combination is ALT GR + 2

@ceasefire95

This comment has been minimized.

Copy link

ceasefire95 commented Jan 31, 2018

+1 really frustrating! Please change the shortcut to something else or let us disable it!

@vinicentus

This comment has been minimized.

Copy link
Contributor

vinicentus commented Jan 31, 2018

+1 So annoying! Can we get a fix ASAP please?
Edit: Using Swedish keyboard layout, problem started with latest stable update

@eljuno

This comment has been minimized.

Copy link
Contributor

eljuno commented Jan 31, 2018

+2 from community https://community.brave.com/t/typing-in-brave-opens-a-new-tab/15067?u=eljuno

One of reporter said s/he used Estonian keyboard.
cc @bsclifton

@aliakyurek

This comment has been minimized.

Copy link

aliakyurek commented Feb 1, 2018

+1 Same for me. Issue started with 0.20.29.
Any attempt to type special characters using Alt gr + number like #,$,[.. opens a new tab.
A hotfix is immediately necessary.
Keyboard layout is Turkish.

@raakis

This comment has been minimized.

Copy link

raakis commented Feb 1, 2018

+1 Same for me. Issue also started with 0.20.29.
Finnish keyboard layout in use.

@srirambv

This comment has been minimized.

Copy link
Collaborator

srirambv commented Feb 1, 2018

This is not specific to any keyboard. Happens even on English keyboard as well. Pressing AltGr + number causes a session tab to open.

Pressing AltGr + number key combination changes to Ctrl+Alt+ as seen in the recording
altgr

Here's what it looks like on 0.19.147
altgr1

Pressing and holding AltGr keeps switching between Ctrl+Alt and Alt although not noticeable on the recording but clearly visible.

@srirambv srirambv added this to the 0.20.x Hotfix 2 milestone Feb 1, 2018

@srirambv srirambv changed the title [BUG] Shortcut for new tab is the same as "@" on Nordic keyboards AltGr + Number opens up a new session tab Feb 1, 2018

@gert7

This comment has been minimized.

Copy link

gert7 commented Feb 2, 2018

+1 for the Estonian keyboard. version 0.20.30

@srirambv

This comment has been minimized.

@eiyey

This comment has been minimized.

Copy link

eiyey commented Feb 3, 2018

+1 from Spanish (Spain) keyboard.

Brave: 0.20.30
V8: 6.4.388.40
rev: 8b78402
Muon: 4.7.9
OS Release: 6.3.9600
Update Channel: Release
OS Architecture: x64
OS Platform: Microsoft Windows
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 64.0.3282.119

@NejcZdovc NejcZdovc modified the milestones: 0.20.x Hotfix 3 (Ledger improvments), 0.20.x Hotfix 2 (Referral Promotion) Feb 5, 2018

@kjozwiak

This comment has been minimized.

Copy link
Member

kjozwiak commented Feb 5, 2018

Thanks for bringing this up in Slack @srirambv! This should definitely get fixed ASAP as it's affecting a large % of the community as demonstrated by all the +1's above.

@Jacalz

This comment has been minimized.

Copy link
Collaborator

Jacalz commented Feb 5, 2018

+1 from me using Swedish keyboard, really annoying

@ElucGeek

This comment has been minimized.

Copy link

ElucGeek commented Feb 6, 2018

+1 from Swiss keyboard and german keyboard. It's a nightmare as it make my password manager entering password in the URL field and send to search engine !

@vinicentus

This comment has been minimized.

Copy link
Contributor

vinicentus commented Feb 6, 2018

The original problem lies here: #6915
A solution: #13015 Note that this would change the shortcut to Control + Shift + [session number] for Windows and Linux and Command + Shift + [session number] Command + Alt + [session number] on Mac OS.

@chrisvanderheyden

This comment has been minimized.

Copy link

chrisvanderheyden commented Feb 8, 2018

+1 from Belgian Keyboard ... This is really a showstopper, i won't be using brave until this gets fixed

@NejcZdovc

This comment has been minimized.

Copy link
Member

NejcZdovc commented Feb 8, 2018

@chrisvanderheyden we reverted PR that broke this one and new version should be out next week. Sorry for your trouble

@LaurenWags

This comment has been minimized.

@daath

This comment has been minimized.

Copy link

daath commented Feb 13, 2018

+1 Just installed to day, eager to start using it - Now I'm forced to wait until a new version without the bug is released - I can't wait :)

@tomasroaldsnes

This comment has been minimized.

Copy link

tomasroaldsnes commented Mar 26, 2018

+1 Norwegian

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.