Skip to content
This repository has been archived by the owner. It is now read-only.

'Notify me about token promotions' switch doesn't work if you've already said 'Maybe Later' #13021

Closed
LaurenWags opened this issue Feb 5, 2018 · 2 comments

Comments

@LaurenWags
Copy link

@LaurenWags LaurenWags commented Feb 5, 2018

Description

If you are prompted for a promotion and you select 'Maybe Later', the remindTimestamp is set to remind you 24h later. If you then go into Adv Settings and toggle 'Notify me about token promotions' off, you will still be reminded 24h later.

Steps to Reproduce

  1. Clean install of 0.20 using ledger_environment=staging.
  2. Get notification.
  3. Select Maybe Later.
  4. Go to Adv Settings, toggle 'Notify me about token promotions' off.
  5. Close Brave.
  6. Open session-store-1 and locate remindTimestamp. Using https://www.epochconverter.com/ you can see that it is set to 24h later.
  7. Change this value to 5-10 minutes from now.
  8. Relaunch Brave (make sure you still use ledger_env staging)

Actual result:
In 30-60 minutes you will be notified about the promotion again.

Expected result:
You should not be notified about the promotion since you toggled the switch to off.

Reproduces how often:
Easily

Brave Version

about:brave info:
0.20.30

Reproducible on current live release:
Yes

Additional Information

Missed when testing #12313

@LaurenWags LaurenWags added this to the 0.20.x Hotfix 3 (Ledger improvments) milestone Feb 5, 2018
@NejcZdovc NejcZdovc self-assigned this Feb 6, 2018
@alexwykoff alexwykoff modified the milestones: 0.20.x Hotfix 3 (Ledger improvments), 0.21.x (Beta Channel) Feb 6, 2018
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 7, 2018
Resolves brave#13021

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Feb 7, 2018
5 of 10 tasks complete
bsclifton added a commit to NejcZdovc/browser-laptop that referenced this issue Feb 15, 2018
Resolves brave#13021

Auditors:

Test Plan:
bsclifton added a commit that referenced this issue Feb 16, 2018
Fixes stop promotions for notifications
bsclifton added a commit that referenced this issue Feb 16, 2018
Fixes stop promotions for notifications
bsclifton added a commit that referenced this issue Feb 16, 2018
Fixes stop promotions for notifications
@NejcZdovc NejcZdovc modified the milestones: 0.21.x (Beta Channel), 0.21.x (Twitch) Feb 24, 2018
NejcZdovc added a commit that referenced this issue Feb 24, 2018
Fixes stop promotions for notifications
@LaurenWags
Copy link
Author

@LaurenWags LaurenWags commented Feb 26, 2018

Removed QA/checked labels due to changes in milestones. Please recheck with 0.21.15 and higher.

@kjozwiak
Copy link
Member

@kjozwiak kjozwiak commented Mar 1, 2018

Before going through verification, I reproduced the original issue using 0.20.30 8b78402 with the STR that @LaurenWags provider above.

Verified using 0.21.18 580be78 under Ubuntu 17.10 x64.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.