This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up'Notify me about token promotions' switch doesn't work if you've already said 'Maybe Later' #13021
Labels
Milestone
Comments
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Feb 7, 2018
Resolves brave#13021 Auditors: Test Plan:
bsclifton
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Feb 15, 2018
Resolves brave#13021 Auditors: Test Plan:
bsclifton
added a commit
that referenced
this issue
Feb 16, 2018
Fixes stop promotions for notifications
bsclifton
added a commit
that referenced
this issue
Feb 16, 2018
Fixes stop promotions for notifications
bsclifton
added a commit
that referenced
this issue
Feb 16, 2018
Fixes stop promotions for notifications
NejcZdovc
added a commit
that referenced
this issue
Feb 24, 2018
Fixes stop promotions for notifications
|
Removed QA/checked labels due to changes in milestones. Please recheck with 0.21.15 and higher. |
ryanml
added a commit
to ryanml/browser-laptop
that referenced
this issue
Feb 27, 2018
Resolves brave#13021 Auditors: Test Plan:
This was referenced Feb 27, 2018
|
Before going through verification, I reproduced the original issue using Verified using |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
If you are prompted for a promotion and you select 'Maybe Later', the remindTimestamp is set to remind you 24h later. If you then go into Adv Settings and toggle 'Notify me about token promotions' off, you will still be reminded 24h later.
Steps to Reproduce
Actual result:
In 30-60 minutes you will be notified about the promotion again.
Expected result:
You should not be notified about the promotion since you toggled the switch to off.
Reproduces how often:
Easily
Brave Version
about:brave info:
0.20.30
Reproducible on current live release:
Yes
Additional Information
Missed when testing #12313