Webtorrent sites not working properly #13060

Open
fabricedesre opened this Issue Feb 7, 2018 · 7 comments

Comments

Projects
None yet
8 participants
@fabricedesre

Description

Sites using Webtorrent are broken.

Steps to Reproduce

  1. Go to a Peertube site, eg. https://video.tedomum.net/ (it's a decentralized alternative to Youtube).
  2. Choose a video and try to play it.

Actual result:

  • If the webtorrent extension is enabled, it is triggered and offers to download the video instead of watching it in the page.
  • If the webtorrent extension is disabled, an error is diplayed, like:
This site can’t be reached
The webpage at chrome-extension://fmdpfempfmekjkcfdehndghogpnpjeno/webtorrent.html#https%3A%2F%2Fpeertube.cpy.re%2Fstatic%2Ftorrents%2Ff78a97f8-a142-4ce1-a5bd-154bf9386504-1080.torrent might be temporarily down or it may have moved permanently to a new web address.
ERR_FAILED

Expected result:

The video should play in the site's interface.

Reproduces how often:

100%

Brave Version

about:brave info:

0.20.30 on Linux 64 bits.

Reproducible on current live release:

I didn't try.

Additional Information

fwiw, playback doesn't work in chromium (it seems to download but doesn't play). Everything is fine in Firefox.

@avenirperma

This comment has been minimized.

Show comment
Hide comment
@avenirperma

avenirperma Apr 12, 2018

same here windows 8.
video on peertube launches torrent via brave and not webtorrent
please help change this, this doesn't help brave for opensource community users!

same here windows 8.
video on peertube launches torrent via brave and not webtorrent
please help change this, this doesn't help brave for opensource community users!

@edgebal

This comment has been minimized.

Show comment
Hide comment
@edgebal

edgebal Apr 24, 2018

As a heads up, the issue is that .torrent files downloaded via XHR/fetch() trigger Brave's torrent extension.

WebTorrent library initiate those .torrent XHR downloads for magnet links that have the &xs=http://example.com/file.torrent query string parameter.

edgebal commented Apr 24, 2018

As a heads up, the issue is that .torrent files downloaded via XHR/fetch() trigger Brave's torrent extension.

WebTorrent library initiate those .torrent XHR downloads for magnet links that have the &xs=http://example.com/file.torrent query string parameter.

@ultimape

This comment has been minimized.

Show comment
Hide comment
@ultimape

ultimape May 1, 2018

Possibly related to #10767 and #10672, which has more details on the topic of webtorrents and fetch() interception.

ultimape commented May 1, 2018

Possibly related to #10767 and #10672, which has more details on the topic of webtorrents and fetch() interception.

@feross

This comment has been minimized.

Show comment
Hide comment
@feross

feross May 23, 2018

Collaborator

Is this issue fixed? It supposedly is, according to #10672

Collaborator

feross commented May 23, 2018

Is this issue fixed? It supposedly is, according to #10672

@fabricedesre

This comment has been minimized.

Show comment
Hide comment
@fabricedesre

fabricedesre May 23, 2018

I still can reproduce on 0.22.714

I still can reproduce on 0.22.714

@feross

This comment has been minimized.

Show comment
Hide comment
@feross

feross May 23, 2018

Collaborator

@NejcZdovc Is this related to the work you were doing in #10767? Any chance you could take a look at this as well?

Collaborator

feross commented May 23, 2018

@NejcZdovc Is this related to the work you were doing in #10767? Any chance you could take a look at this as well?

@NejcZdovc

This comment has been minimized.

Show comment
Hide comment
@NejcZdovc

NejcZdovc May 23, 2018

Member

@feross I don't think so, but I can take a look

Member

NejcZdovc commented May 23, 2018

@feross I don't think so, but I can take a look

@NejcZdovc NejcZdovc self-assigned this May 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment