This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upfavicons are not consistently displayed in the ledger table #13281
Labels
Milestone
Comments
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Feb 23, 2018
Resolves brave#13281 Auditors: Test Plan:
Merged
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Feb 25, 2018
Resolves brave#13281 Auditors: Test Plan:
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Feb 25, 2018
Resolves brave#13281 Auditors: Test Plan:
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Feb 25, 2018
Resolves brave#13281 Auditors: Test Plan:
bsclifton
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Feb 26, 2018
Resolves brave#13281 Auditors: Test Plan:
NejcZdovc
added a commit
to NejcZdovc/browser-laptop
that referenced
this issue
Feb 26, 2018
Resolves brave#13281 Auditors: Test Plan:
ryanml
added a commit
to ryanml/browser-laptop
that referenced
this issue
Feb 27, 2018
Resolves brave#13281 Auditors: Test Plan:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
@srirambv and I are not seeing favicons displayed consistently in the ledger table.
Steps to Reproduce
Actual result:
Sites may or may not display their favicons when returned to the table. In the screenshot below all sites had been removed at one time or another (all sites had favicons prior to deleting from the table). Two of them got favicons back, but the others did not.
Expected result:
All sites should have favicons.
Reproduces how often:
Most of the time, but not 100%
Brave Version
about:brave info:
0.21.12
Reproducible on current live release:
Additional Information
@srirambv sometimes doesn't see favicons added when sites are added to the ledger table initially.
cc @NejcZdovc