Skip to content
This repository has been archived by the owner. It is now read-only.

Recovery Code isn't localized for other languages #13311

Closed
srirambv opened this issue Feb 26, 2018 · 1 comment
Closed

Recovery Code isn't localized for other languages #13311

srirambv opened this issue Feb 26, 2018 · 1 comment

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Feb 26, 2018

Test plan

#13321

Description

Recovery Code isn't localized for other languages

Steps to Reproduce

  1. Clean install 0.20.46 build, Set browser language to English (U.K)
  2. Enable wallet
  3. Print recovery keys, shows Recovery Code 2

Actual result:
recovery keys

Expected result:
Should not show Recovery Code 2 either in print keys or on saved keys

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.20.46
V8 6.4.388.41
rev 5eb035c
Muon 4.8.2
OS Release 10.0.16299
Update Channel Release
OS Architecture x64
OS Platform Microsoft Windows
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 64.0.3282.140

Reproducible on current live release:
Yes

Additional Information

@kjozwiak
Copy link
Member

@kjozwiak kjozwiak commented Feb 28, 2018

Went through the following languages using 0.21.17 57e6145 under Ubuntu 17.10 x64 and ensured that Recovery Code 2 wasn't be displayed when backing up the recovery codes via both Print and Save methods:

  • English (U.K) - PASSED
  • French - PASSED
  • Slovenian - PASSED
  • Russia - PASSED
  • Japanese - PASSED
  • Italian - PASSED
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.