Skip to content
This repository has been archived by the owner. It is now read-only.

URL Parsing fails for query string and file name with space #13897

Closed
AlexWang-16 opened this issue Apr 23, 2018 · 0 comments · Fixed by #13898

Comments

@AlexWang-16
Copy link

@AlexWang-16 AlexWang-16 commented Apr 23, 2018

Test plan

See #13898

Original issue description

Description

• Brave does not parse URL correctly when a space is in the query string. It performs a google search on the URL instead of the topic indicated by the query string

• Brave does not parse absolute paths with a space in file name correctly

Steps to Reproduce

Issue 1: Brave does not parse space in query string as valid URL

  1. Go to address bar
  2. Enter "Https://www.google.com/search?q=dog cat"
  3. Press enter

Issue 2: Brave does not parse absolute paths with a space in file name correctly

Windows:

  1. Go to address bar
  2. Enter "C:\Path\to\file\with space"
  3. Press enter

Linux/Mac:

  1. Go to adress bar
  2. Enter "/Path/to/file/with space"
  3. Press enter

Actual result:
Issue 1:
Brave loads google and performs a search on "https://www.google.com/search?q=dog cat"

google_search_problem

Issue 2 (Windows): Brave loads google and performs a search on "C:\Path\to\file\with space"

path_windows_problem

Issue 2 (Mac/Linux): Brave loads google and performs a search on "/Path/to/file/with space"

path_mac_problem

Expected result:
Issue 1: Brave loads google and performs a search on "dog cat"

Issue 2 (Windows): Brave should convert path to "file:///C:/Path/to/file/with%20space". The body of the page should say file not found.

Issue 3 (Mac/Linux): Brave should convert the path to "/Path/to/file/with%20space". The body of the page should say file not found.

Reproduces how often:
100%

Brave Version

about:brave info:

Brave: 0.22.0
V8: 6.5.254.41
rev: fcf1667
Muon: 5.1.2
OS Release: 17.5.0
Update Channel:
OS Architecture: x64
OS Platform: macOS
Node.js: 7.9.0
libchromiumcontent: 65.0.3325.181

Reproducible on current live release:
Yes

@bsclifton bsclifton added this to the Completed work milestone Apr 30, 2018
@bsclifton bsclifton mentioned this issue May 1, 2018
0 of 10 tasks complete
@diracdeltas diracdeltas modified the milestones: Completed work, 0.25.x (coming soon) May 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.