Skip to content
This repository has been archived by the owner. It is now read-only.

external protocol prompt does not appear on about: pages #14679

Closed
diracdeltas opened this issue Jul 6, 2018 · 9 comments
Closed

external protocol prompt does not appear on about: pages #14679

diracdeltas opened this issue Jul 6, 2018 · 9 comments

Comments

@diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Jul 6, 2018

STR:

  1. go to about:newtab (or just open a new tab)
  2. enter 'mailto:test' in the url bar
  3. note that the mail app opens without showing a permission prompt

whereas if you do step 2 on a page such as google.com, the permission prompt appears as expected.

EDIT: marked as tor due to https://hackerone.com/bugs?subject=brave&report_id=388494

@diracdeltas

This comment has been minimized.

Copy link
Member Author

@diracdeltas diracdeltas commented Jul 6, 2018

i thought we fixed this at some point so maybe this is a regression. can't find the original issue though.

@btlechowski

This comment has been minimized.

Copy link
Contributor

@btlechowski btlechowski commented Jul 7, 2018

Original issue: #13643.

@diracdeltas

This comment has been minimized.

Copy link
Member Author

@diracdeltas diracdeltas commented Jul 31, 2018

@diracdeltas

This comment has been minimized.

Copy link
Member Author

@diracdeltas diracdeltas commented Jul 31, 2018

I don't think #13643 is the original issue since that STR was for URLs entered on a remote site like google.com whereas this bug only happens on about: pages.

@riastradh-brave

This comment has been minimized.

Copy link
Contributor

@riastradh-brave riastradh-brave commented Jul 31, 2018

Can sites do this or do you have to type it into the URL bar?

@diracdeltas

This comment has been minimized.

Copy link
Member Author

@diracdeltas diracdeltas commented Jul 31, 2018

@riastradh-brave sites can do it via a redirect to a custom protocol (ssh://...) apparently

diracdeltas added a commit that referenced this issue Jul 31, 2018
quick fix for
#14679 (comment)
by just removing the special exception for these origins. this probably
breaks something but i'm not sure what.
@diracdeltas

This comment has been minimized.

Copy link
Member Author

@diracdeltas diracdeltas commented Jul 31, 2018

#14681 is related, probably fixed by the same muon fix

riastradh-brave added a commit that referenced this issue Jul 31, 2018
quick fix for
#14679 (comment)
by just removing the special exception for these origins. this probably
breaks something but i'm not sure what.
@riastradh-brave riastradh-brave mentioned this issue Jul 31, 2018
5 of 10 tasks complete
@riastradh-brave

This comment has been minimized.

Copy link
Contributor

@riastradh-brave riastradh-brave commented Aug 1, 2018

Immediate symptom is fixed by #14887, but may be other latent issues, for which see #14897.

@srirambv

This comment has been minimized.

Copy link
Collaborator

@srirambv srirambv commented Aug 2, 2018

Verified on Windows10 x64 ysing

  • 0.23.74 b508fa7
  • Muon 8.0.4
  • libchromiumcontent 68.0.3440.84
  • Verified on normal/private/Tor tabs

Verified on Ubuntu 17.10 x64

  • 0.23.74 c3d448a
  • Muon 8.0.4
  • libchromiumcontent 68.0.3440.84

Verified with macOS 10.12.6 using

  • 0.23.74 b508fa7
  • Muon 8.0.4
  • libchromiumcontent 68.0.3440.84
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
8 participants
You can’t perform that action at this time.