Skip to content
This repository has been archived by the owner. It is now read-only.

Tab Settings Panel #2137

Closed
bradleyrichter opened this issue Jun 8, 2016 · 21 comments
Closed

Tab Settings Panel #2137

bradleyrichter opened this issue Jun 8, 2016 · 21 comments

Comments

@bradleyrichter
Copy link
Contributor

@bradleyrichter bradleyrichter commented Jun 8, 2016

Functionality:

The tab settings panel for 1.0 includes user definable items.

  1. The choice to open new tabs to the right of the current tab or at the end of the tab sequence.
  2. Changing the default setting for how many tabs are displayed in each tab set.
  3. Ability to disable the tab previews feature.
  4. Ability to disable the tab coloration which is based on theme or background top color.

Strings:

Title:
"Tab Settings"

Open new tabs item string:
"Open new tabs"

Option strings:
"To the right"
"At the end"

Tab set number item string:
"Number of tabs per tab-set:"

Option strings:
"6"
"8"
"10"
"20"

Tab preview switch string:
"Show tab previews on mouse-hover"

Tab color item string:
"Show tabs in page theme color"

Spec image:
image

@bradleyrichter bradleyrichter added this to the 0.11.0dev milestone Jun 8, 2016
@bradleyrichter bradleyrichter changed the title Tab Settings: Tab Settings Panel Jun 8, 2016
@ghost
Copy link

@ghost ghost commented Jul 7, 2016

Would be also great if we users would be able to decide where we can have the placement of a new opened tab - at the end of all tabs, or to the right/left of the active tab. As this is also a very basic tab functionality.

@bbondy bbondy modified the milestone: 0.11.1dev Jul 11, 2016
@bradleyrichter
Copy link
Contributor Author

@bradleyrichter bradleyrichter commented Jul 11, 2016

@SJ-Diamond

Added it into 1.0 just for you : )

@bradleyrichter
Copy link
Contributor Author

@bradleyrichter bradleyrichter commented Jul 11, 2016

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Jul 20, 2016

Cycle tabs between most recently used would be a good option too.

@luixxiul luixxiul added this to the 1.0.0 milestone Nov 14, 2016
@yannduran
Copy link

@yannduran yannduran commented Jan 8, 2017

👍

@NejcZdovc
Copy link
Member

@NejcZdovc NejcZdovc commented Jan 11, 2017

@bradleyrichter I will implement Open new tabs and would like to know if we still use side by side positioning or is everything one after another. I also added #6553 so we will have 3 dropdowns now.

@NejcZdovc
Copy link
Member

@NejcZdovc NejcZdovc commented Jan 11, 2017

@luixxiul you mentioned in #6553 that you would like to design this panel, I am ready to implement Open new tabs drop down 😃

@NejcZdovc
Copy link
Member

@NejcZdovc NejcZdovc commented Jan 31, 2017

I think that when #6907 is done, this issue can be closed

@bradleyrichter
Copy link
Contributor Author

@bradleyrichter bradleyrichter commented Jan 31, 2017

revision to this original issue and more!

image

@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Feb 1, 2017

BTW @bradleyrichter have you known the sync icon on the left bar would be replaced with the pyramids one?

@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Feb 1, 2017

@NejcZdovc if you would create a PR to add "Open new tabs" dropdown, I would like to add design commits to the PR to close the issue.

@luixxiul luixxiul self-assigned this Feb 1, 2017
@NejcZdovc
Copy link
Member

@NejcZdovc NejcZdovc commented Feb 1, 2017

@luixxiul it's already here 😄 #6958, but there is something wrong with muon and we are trying to solve this on slack

@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Feb 1, 2017

Yeah I noticed it just now. I will create a PR to polish if necessary and close the issue :-)

@luixxiul luixxiul modified the milestones: 0.13.3, 0.13.2 Feb 1, 2017
@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Feb 1, 2017

I reset the milestone to 0.13.3 based on the instruction by @bbondy

@bbondy bbondy modified the milestones: 0.13.2, 0.13.3 Feb 1, 2017
@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Feb 1, 2017

#6982 asks @bradleyrichter to revise the mockup again.

@NejcZdovc
Copy link
Member

@NejcZdovc NejcZdovc commented Mar 25, 2017

@luixxiul @bradleyrichter what is still missing here?

@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Mar 25, 2017

I've forgotten it, sorry I'm not sure.

@NejcZdovc
Copy link
Member

@NejcZdovc NejcZdovc commented May 12, 2017

I will close this one, if we are missing something, please reopen.

@NejcZdovc NejcZdovc closed this May 12, 2017
@luixxiul luixxiul removed this from the 1.0.0 milestone May 15, 2017
@brendaalicia
Copy link

@brendaalicia brendaalicia commented Dec 8, 2018

Hello, I just updated my browser to the new version and I can't find the option "Number of tabs per tab-set". Can anyone help me?

@bsclifton
Copy link
Member

@bsclifton bsclifton commented Jan 3, 2019

Hi @brendaalicia (sorry for the late response)

That feature isn't present in the new version of Brave yet. You can track progress by subscribing to brave/brave-browser#35 😄

@brendaalicia
Copy link

@brendaalicia brendaalicia commented Jan 3, 2019

@bsclifton Thank you 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
8 participants
You can’t perform that action at this time.