Skip to content
This repository has been archived by the owner. It is now read-only.

Linux application name changes to a url and does not revert. #3492

Closed
alexwykoff opened this issue Aug 27, 2016 · 2 comments
Closed

Linux application name changes to a url and does not revert. #3492

alexwykoff opened this issue Aug 27, 2016 · 2 comments

Comments

@alexwykoff
Copy link
Contributor

@alexwykoff alexwykoff commented Aug 27, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
After creating a bookmark, I noticed that the application name for Brave changed to the URL which was bookmarked.

Expected behavior:
The name should remain 'Brave'

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Tested on Ubuntu.
  • Brave Version:
    0.11.6 pre-beta5
  • Steps to reproduce:
    1. Install the latest build on Ubuntu.
    2. Bookmark a site.
    3. Search for the Brave app via the launcher.
  • Screenshot if needed:
    screen shot 2016-08-27 at 4 12 25 pm
  • Any related issues:
@alexwykoff alexwykoff added this to the 0.11.6dev milestone Aug 27, 2016
@bbondy
Copy link
Member

@bbondy bbondy commented Aug 28, 2016

I think it shows the current window title which is the title of the url, and since there is no title it shows the URL. This is probably the same as all past issues so I don't think we have to block on it. I'm assuming the application is open?

Could you confirm that's the case.
Also what is the expected result, and how does chrome/firefox differ?

@bbondy bbondy removed this from the 0.11.6dev milestone Aug 28, 2016
@alexwykoff
Copy link
Contributor Author

@alexwykoff alexwykoff commented Sep 27, 2016

After further investigation, it turns out that an Ubuntu user has an 'Add to Dash' option from the context menu of the launcher.
This creates a file .local/share/applications/brave.desktop
The content of the file is as follows:
test@test:~/.local/share$ cat applications/brave.desktop [Desktop Entry] Encoding=UTF-8 Version=1.0 Type=Application Name=Preferences Icon=brave Path=/home/test/BraveQA/0.12.3/rc1 Exec=/usr/share/brave/brave StartupNotify=false StartupWMClass=brave OnlyShowIn=Unity; X-UnityGenerated=true

The Name variable is being set to the current tab, it should be set to 'Brave'.
The Path variable is being set to the location of the .deb file which was used for installing, it probably should be set to the location of the application proper.
test@test:~/.local/share$ which brave /usr/bin/brave

@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@bsclifton bsclifton added the wontfix label Sep 18, 2018
@bsclifton bsclifton closed this Sep 18, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Sep 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.