Skip to content
This repository has been archived by the owner. It is now read-only.

Enable in-browser proxy settings option #3756

Closed
putt1ck opened this issue Sep 6, 2016 · 62 comments

Comments

Projects
None yet
@putt1ck
Copy link

commented Sep 6, 2016

No description provided.

@putt1ck

This comment has been minimized.

Copy link
Author

commented Sep 6, 2016

There is no UI option to enable a proxy; using a system-wide proxy is not always the preferred option. Having a UI access to set a browser-specific proxy, or use no proxy when there is one set system-wide is literally expected behaviour for cross-platform browsers, as well as necessary in a number of use cases, including web development scenarios, IT support scenarios, parenting scenarios.

Platform: OpenSUSE Tumbleweed (assuming affects any OS)
Brave: latest (and before)

#770 #1111

@luixxiul luixxiul added the suggestion label Sep 6, 2016

@joshuayabut

This comment has been minimized.

Copy link

commented Sep 28, 2016

I have some commits ready to enable session-based proxy settings. Since there are still a bunch of electron related leaks it's quite unsafe to use for those with privacy requirements though.

A couple thoughts/options:

  • use chromium's behavior (point to the system-wide proxy config window)
  • wait to enable this until the leaks are resolved
  • add a warning prompt when adding a session-based proxy setting

@luixxiul luixxiul added the privacy label Sep 28, 2016

@alexwykoff

This comment has been minimized.

Copy link
Member

commented Oct 19, 2016

@andrewcole50

This comment has been minimized.

Copy link

commented Nov 19, 2016

It may be worth looking into how Epic Privacy Browser does this. I really like how they implement this into their browser. https://www.epicbrowser.com/our-key-features.html

@efemernyy

This comment has been minimized.

Copy link

commented Nov 28, 2016

This feature is a necessity for me, would love to switch to Brave full time but no native proxy/network settings interface kills it

@dhiva

This comment has been minimized.

Copy link

commented Dec 25, 2016

it would be great if brave has inbuild smart proxy switcher which could allow you to configure multiple proxies for various different sites and automatically use them when the site is visited.

@SillonBono

This comment has been minimized.

Copy link

commented Jan 4, 2017

Having a configurable proxy option is a must. Having the possibility to configure multiple proxies and switch to them either by site list or by drop down menu would be icing on the cake.

Most organizations use a proxy for web browsing and many use multiple proxies.

@luixxiul luixxiul added this to the Backlog milestone Jan 4, 2017

@codfather

This comment has been minimized.

Copy link

commented Jan 10, 2017

I would like to add my support for this addition to the browser. I now use this browser for work, and it is a necessity to have a per application ability to support proxies, as system wide are just not appropriate for Devops type work. I look forward to this addition.

@bsclifton

This comment has been minimized.

Copy link
Member

commented Feb 7, 2017

I'm not sure how much we've diverged from Electron, but we may be able to get this functionality by hooking into the sessions object
http://electron.atom.io/docs/api/session/#sessetproxyconfig-callback

cc: @bridiver

@alexwykoff alexwykoff modified the milestones: 1.1.0, Backlog Mar 8, 2017

@mannp

This comment has been minimized.

Copy link

commented Jul 30, 2017

Wondered if there are any updates on this one at all?

Seems you may have a solution? but its been pushed back to v1.1 release.

@srirambv

This comment has been minimized.

Copy link
Collaborator

commented Aug 17, 2017

@Rogerborg

This comment has been minimized.

Copy link

commented Aug 28, 2017

+1 for this being a show stopper for me using Brave. It seems unbelievable that a browser with the user's interests and privacy at heart wouldn't support this.

@luixxiul

This comment has been minimized.

Copy link
Contributor

commented Aug 28, 2017

wouldn't

Not exactly; it's planned.

@netroby

This comment has been minimized.

Copy link

commented Sep 6, 2017

+1 need this

@tomonova

This comment has been minimized.

Copy link

commented Sep 21, 2017

+1 this truly is important feature, please deliver on this ASAP

@CapitanShinChan

This comment has been minimized.

Copy link

commented Sep 27, 2017

Point to the system proxy is a dirty solution that almost all modern browsers do (good job Firefox, you're one of the few who is doing it in the right way). Hope Brave will imitate the Firefox behavior.

@netroby

This comment has been minimized.

Copy link

commented Sep 27, 2017

@JakRowan

This comment has been minimized.

Copy link

commented Sep 29, 2017

+1 Absolutely necessary feature. Brave will completely replace my Firefox usage once this is implemented.

@Laomak

This comment has been minimized.

Copy link

commented Oct 18, 2017

+1 I also need this feature to finally get rid of Firefox and their recent introduced Cliqz support

@dannwebb

This comment has been minimized.

Copy link

commented Oct 29, 2017

+1 I'll also be leaving Firefox for Brave when this is implemented.

@alexwykoff alexwykoff modified the milestones: 1.1.0, Backlog Nov 1, 2017

@jSadoski

This comment has been minimized.

Copy link

commented Apr 8, 2018

I wanted to comment to +1 this as a crucial feature, but I would also like to address the nature of some of the feedback I see here.

I find that some of it is not really in the spirit of Github Community Guidelines (https://help.github.com/articles/github-community-guidelines/) or the nature of open-source un general. We're all here, even as non-developers, to see that Brave reaches its full potential. While this does prevent me from using Brave as my daily driver as well, I'm very grateful so far for the work that's been done. I have faith that they will take our feedback in all seriousness and will implement it when they can.

Want it to happen faster? Contribute to Brave: https://medium.com/margarytachepiga/how-to-contribute-to-brave-dbbe184631c3

@hieronymousch

This comment has been minimized.

Copy link

commented Apr 10, 2018

+1

@nielspeen

This comment has been minimized.

Copy link

commented Apr 16, 2018

Brave properly uses the system proxy on macOS when one is configured. However, when I then remove the system proxy, and other browsers automatically switch back to the regular connection, Brave stops working and reports: "The IP address is unreachable. This usually means that there is no route to the specified host or network."

@jSadoski

This comment has been minimized.

Copy link

commented Apr 16, 2018

@nielspeen That issue doesn't sound related to this feature request. You should open your own issue for that.

@charlierlee

This comment has been minimized.

Copy link

commented Apr 23, 2018

+1

@pepik

This comment has been minimized.

Copy link

commented Apr 24, 2018

+1

On a mac, while connected to corporate network using Cisco Anyconnect VPN, brave browser us usable for internal web pages only.

System wide pac-provided proxy does not work.

@motorious1

This comment has been minimized.

Copy link

commented May 3, 2018

+1
same issue as pepik here...
FF has the following which I would need comparable to in Brave to use on corporate network
Options -> Advanced -> Network -> Connection -> Settings ->"Automatic proxy configuration URL:"

@Adiorz

This comment has been minimized.

Copy link

commented May 5, 2018

+1
same here - lack of proxy support discards Brave for me

@ecomaikgolf

This comment has been minimized.

Copy link

commented May 19, 2018

+1

@binchick-in

This comment has been minimized.

Copy link

commented Jun 1, 2018

+1?

Is this going to happen?

@putt1ck

This comment has been minimized.

Copy link
Author

commented Jun 2, 2018

Rumour has it that the rewrite underway for v1 will include this feature (via Twitter). Probably won't be independent of the system proxy though, as they'll inherit the feature from the Chromium code base (my ideal is per-browser, though only for testing "kid-quality web filtering")

@bsclifton

This comment has been minimized.

Copy link
Member

commented Jun 5, 2018

When we switch over to the new Chromium based UI (Brave Core), we should have the exact same behavior as Chrome/Chromium

I tested this on macOS and Windows 10 and it looks opening Proxy settings (under chrome://settings) simply opens up the system settings.

Is there a different UI exposed in Chrome that I'm missing? I didn't see anything under chrome://chrome-urls/. Maybe there are command line options?

@boistordu

This comment has been minimized.

Copy link

commented Jun 5, 2018

this is a simple problem. We don't need a vpn proxy settings. We need an extension which will do the switching. Nobody is using the in-house windows proxy settings because it works poorly.

@beickhoff

This comment has been minimized.

Copy link

commented Jun 5, 2018

+1
This is a show stopper for me.

@boistordu

This comment has been minimized.

Copy link

commented Jun 5, 2018

I don't understand why they can't see as a primary function with this actual historic context.

@bsclifton

This comment has been minimized.

Copy link
Member

commented Jun 5, 2018

@boistordu it's not a simple problem given our current codebase (Muon, forked from Electron) and our current set of priorities (otherwise, we or a contributor would have finished it already).

If you're not using Brave, what is your solution? Are you using Chrome with an extension?

@CapitanShinChan

This comment has been minimized.

Copy link

commented Jun 5, 2018

Firefox

@mplungjan

This comment has been minimized.

Copy link

commented Jun 5, 2018

@beickhoff

This comment has been minimized.

Copy link

commented Jun 5, 2018

Currently using Firefox

@boistordu

This comment has been minimized.

Copy link

commented Jun 5, 2018

@bsclifton yes I'm using, depending of the machine, chromium, chrome or firefox. All with an extension which is here: https://github.com/FelisCatus/SwitchyOmega which is available on every platform and since the code is available then we can maybe translate the needed part for your browser.

@tofke

This comment has been minimized.

Copy link

commented Jun 10, 2018

+1

@BrendanEich

This comment has been minimized.

Copy link
Member

commented Jun 13, 2018

This issue will not apply to brave-core (aka chromium-fork). Still would be good to get relief sooner but brave-core is coming up fast and we will switch desktop over to it from Muon ASAP.

@rouxianmantou

This comment has been minimized.

Copy link

commented Aug 2, 2018

+1
request to add in-browser proxy switcher or an extension like which named SwitchyOmega(support both chrome and firefox) mentioned above...

@tomlowenthal

This comment has been minimized.

Copy link
Member

commented Aug 7, 2018

This will be available in brave-core, and won't be fixed in Muon.

@tomlowenthal tomlowenthal added the wontfix label Aug 7, 2018

@bsclifton bsclifton removed this from the Backlog (Prioritized) milestone Aug 24, 2018

@boompig

This comment has been minimized.

Copy link

commented Sep 7, 2018

I don't see this in the MacOS X version. Am I missing something?

@bsclifton

This comment has been minimized.

Copy link
Member

commented Sep 8, 2018

@boompig have you downloaded the new Developer channel release?
https://brave.com/download-dev

Give this a try- it should be fixed there

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.