Skip to content
This repository has been archived by the owner. It is now read-only.

Idle timer never stopping the ledger timer #4051

Closed
da2x opened this issue Sep 16, 2016 · 7 comments
Closed

Idle timer never stopping the ledger timer #4051

da2x opened this issue Sep 16, 2016 · 7 comments
Assignees
Milestone

Comments

@da2x
Copy link
Contributor

@da2x da2x commented Sep 16, 2016

Left my browser open over night. This added 7 hours to the ledger timer of the website that was left open in Brave. Apparently the idle timer isn’t triggered or is ignored.

Brave version 0.12.1dev, Fedora 24 64-bit.

@mrose17
Copy link
Member

@mrose17 mrose17 commented Sep 21, 2016

@bridiver - can you take a quick look at this? thanks!

@bridiver
Copy link
Collaborator

@bridiver bridiver commented Sep 21, 2016

haven't tested it on Fedora, but I wonder if there is something else preventing the idle notification. The idle status is system-wide and not just for Brave. @mrose17 I assume he should see the timer start and stop with ledger logging enabled? It should kick in after 15 minutes of inactivity or on lock - https://developer.chrome.com/apps/idle

@mrose17
Copy link
Member

@mrose17 mrose17 commented Sep 21, 2016

@alexwykoff - could someone internally try to reproduce this? (i'm away from my VMs...) thanks!

@bridiver
Copy link
Collaborator

@bridiver bridiver commented Sep 21, 2016

I can look later as well, but I need to setup a Fedora VM. We are using Ubuntu for builds/testing

@mrose17
Copy link
Member

@mrose17 mrose17 commented Sep 22, 2016

@Aeyoun - thanks again for reporting this. i may have found the issue. i will circle back in a bit.

@mrose17 mrose17 self-assigned this Sep 22, 2016
@mrose17 mrose17 added this to the 0.12.3dev milestone Sep 22, 2016
mrose17 added a commit that referenced this issue Sep 22, 2016
fixes #4051
@mrose17
Copy link
Member

@mrose17 mrose17 commented Sep 22, 2016

i'm pretty sure that #4186 fixes this. the idle timer is 15m.

note that a future revision may ignore the idle timer if audioPlaybackActive: true

@mrose17
Copy link
Member

@mrose17 mrose17 commented Sep 22, 2016

Fixed #4194

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.