Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upIdle timer never stopping the ledger timer #4051
Comments
|
@bridiver - can you take a quick look at this? thanks! |
|
haven't tested it on Fedora, but I wonder if there is something else preventing the idle notification. The idle status is system-wide and not just for Brave. @mrose17 I assume he should see the timer start and stop with ledger logging enabled? It should kick in after 15 minutes of inactivity or on lock - https://developer.chrome.com/apps/idle |
|
@alexwykoff - could someone internally try to reproduce this? (i'm away from my VMs...) thanks! |
|
I can look later as well, but I need to setup a Fedora VM. We are using Ubuntu for builds/testing |
|
@Aeyoun - thanks again for reporting this. i may have found the issue. i will circle back in a bit. |
|
i'm pretty sure that #4186 fixes this. the idle timer is 15m. note that a future revision may ignore the idle timer if |
|
Fixed #4194 |
Left my browser open over night. This added 7 hours to the ledger timer of the website that was left open in Brave. Apparently the idle timer isn’t triggered or is ignored.
Brave version 0.12.1dev, Fedora 24 64-bit.