Skip to content
This repository has been archived by the owner. It is now read-only.

synopsis entry should show up in < 8s for tests #4122

Closed
diracdeltas opened this issue Sep 20, 2016 · 2 comments
Closed

synopsis entry should show up in < 8s for tests #4122

diracdeltas opened this issue Sep 20, 2016 · 2 comments
Assignees
Milestone

Comments

@diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Sep 20, 2016

Did you search for similar issues before submitting this one?
yes

Describe the issue you encountered:
when process.env.NODE_ENV === 'test' and a page is visited, it takes 8 seconds for a page to be registered in the ledger, which makes it impossible to test because the test timeout is less than 8s. i thought this was fixed by e47c28b but apparently not.

to repro:

  1. mkdir ~/.brave-test-ledger
  2. NODE_ENV=test npm start
  3. open the payments panel, visit any site, observe that it takes at least 8s for it to appear in the synopsis table
@mrose17
Copy link
Member

@mrose17 mrose17 commented Sep 22, 2016

@diracdeltas - still looking into this, but. if you do NODE_ENV=test ..., then everything in the browser EXCEPT the ledger file are in ~/Application\ Support/brave-test/ -- but the ledger files are looked for in ~/.brave-test-ledger/, but that directory is never created automatically. i'm going to address that in the PR associated with this issue.

mrose17 added a commit that referenced this issue Sep 22, 2016
@mrose17 mrose17 modified the milestones: 0.12.2dev, 0.12.3dev Sep 22, 2016
@diracdeltas
Copy link
Member Author

@diracdeltas diracdeltas commented Sep 22, 2016

@mrose17 the testing framework doesn't know where appData is so it has to use ~/. the directory is made automatically by the test setup script, so make sure to change test/lib/brave.js accordingly if you make any changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.