Skip to content
This repository has been archived by the owner. It is now read-only.

Add styling to make "Merge Favorites" appear aligned (in Import Bookmark modal) #4152

Closed
srirambv opened this issue Sep 21, 2016 · 5 comments
Closed
Assignees
Labels

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Sep 21, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Merge Favourite into bookmark not properly aligned in Import Bookmark modal

Expected behavior:
Should be properly aligned

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64
  • Brave Version:
    0.12.2 RC1
  • Steps to reproduce:
    1. Open preferences, Click on Import Bookmarks
    2. Merge Favourite into Bookmark is not properly aligned
      3.
  • Screenshot if needed:
    image
  • Any related issues:
    cc: @darkdh
@srirambv srirambv added this to the 0.12.2dev milestone Sep 21, 2016
@darkdh
Copy link
Member

@darkdh darkdh commented Sep 22, 2016

This is intended because it is the sub option of importing bookmark.
Maybe we need other way to present the sub option, @bradleyrichter?

@bbondy bbondy removed this from the 0.12.2dev milestone Sep 22, 2016
@luixxiul luixxiul added invalid and removed feature/importer labels Feb 1, 2017
@luixxiul luixxiul closed this Feb 1, 2017
@bradleyrichter
Copy link
Contributor

@bradleyrichter bradleyrichter commented Feb 1, 2017

This will be improved soon:

image

@bsclifton
Copy link
Member

@bsclifton bsclifton commented Feb 1, 2017

Let's reopen and use this to track the change @bradleyrichter has shown 😄

@bsclifton bsclifton reopened this Feb 1, 2017
@bsclifton bsclifton changed the title Merge Favourite into bookmark not properly aligned in Import Bookmark modal Add styling to make "Merge Favorites" appear aligned (in Import Bookmark modal) Feb 1, 2017
@bsclifton bsclifton added design and removed invalid labels Feb 1, 2017
@bradleyrichter
Copy link
Contributor

@bradleyrichter bradleyrichter commented Feb 1, 2017

@cezaraugusto just made a new, smaller switch style so we only need the "L"...

@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented May 28, 2017

Closing this in favor of #7194, 46e3919

@luixxiul luixxiul closed this May 28, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants
You can’t perform that action at this time.