Right click on draggable areas on some platforms shows system menu

[bsclifton]

Did you search for similar issues before submitting this one?
yes

Describe the issue you encountered:
I suspect this is a Windows only issue (no other platforms use the electron frameless style). If you right click on a draggable area, you'll get the system menu.

This is expected behavior on some platforms per the docs but it's not ideal.

Expected behavior:
We should be able to capture this event and show our own custom menu.

This will require a change to electron- the current behavior (per the docs link above) does not have any flexibility. Draggable areas will show the system menu.

• Platform (Win7, 8, 10? macOS? Linux distro?):
  All Windows versions
• Brave Version:
  0.12.2 and newer
• Steps to reproduce:
  1. Launch Brave
  2. Right click on any draggable area
     3. Notice the system menu
• Screenshot if needed:
  

- Any related issues:

[Sh1d0w]

@bsclifton I use my custom frameless build of Brave (the original one by me) on Linux and this is not reproducible, so yes it seems like windows only issue. Just to mention it if it helps :)

[alexwykoff]

closing as duplicate of #4171

[luixxiul]

Actually this covers both #4171 and #4232 instead of being just a dupe of the former.

[bsclifton]

Reopening- there is nothing we can do about the behavior at the moment; it's expected and documented behavior per electron.

However, we can consider making changes to electron to override or change this behavior. This issue is intended to track our efforts investigating that (and would likely be dependent on an electron PR being accepted before it can be closed).

[bsclifton]

The solution to this might be to intercept the WM_SYSCOMMAND event in Muon and look through registered menus which have an associated RECT (that is up to the user to register). If no applicable ones are found, THEN do the default behavior (showing the borderline-useless system menu)
(for more info see https://msdn.microsoft.com/en-us/library/windows/desktop/ms646360(v=vs.85).aspx)

[bsclifton]

This unfortunately is not an issue we'll be able to address before moving to brave-core. When moving to brave-core, we'll be using the Chromium UI instead of a custom HTML/JavaScript UI we maintain ourselves (via Muon), so this issue will be resolved