Skip to content
This repository has been archived by the owner. It is now read-only.

Nested bookmark folders go off screen in bookmarks toolbar #4745

Closed
bsclifton opened this Issue Oct 13, 2016 · 16 comments

Comments

Projects
None yet
8 participants
@bsclifton
Copy link
Member

bsclifton commented Oct 13, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
When user has a large amount of nested bookmark folders, they'll end up going off screen instead of being able to show all the folders.

Expected behavior:
Folders should show (see screenshot below, with Chrome behavior)

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All
  • Brave Version:
    All
  • Steps to reproduce:
    1. Go to about:bookmarks
    2. Create 20 - 30 folders and nest them all
    3. Ensure bookmarks toolbar is being shown
    4. Open the folder using bookmarks toolbar
  • Screenshot if needed:

screenshot from 0.12.5
screen shot 2016-10-13 at 7 01 37 pm

screenshot showing Brave (top) vs Chrome (bottom) behavior (thanks @srirambv!)
image

  • Any related issues:
    #1187
@bsclifton

This comment has been minimized.

Copy link
Member Author

bsclifton commented May 16, 2017

+1 from #8891 (bookmarks toolbar expansion menus are running past the right edge of the window)

@srirambv

This comment has been minimized.

Copy link
Collaborator

srirambv commented Aug 10, 2017

+1 from #10388

@LaurenWags

This comment has been minimized.

Copy link

LaurenWags commented Sep 1, 2017

+1 from me

@alexwykoff

This comment has been minimized.

Copy link
Member

alexwykoff commented Sep 1, 2017

@bsclifton what is blocking this? Does it depend on any DPI fixes?

@bsclifton

This comment has been minimized.

Copy link
Member Author

bsclifton commented Sep 1, 2017

@alexwykoff no blockers

In order to solve this, we would need to convert the menus from React controls (HTML/JavaScript) to native menu items (ex: uses win32 / gtk / cocoa). We've done this with a few menus (ex: the popup menu that shows when you right click a page), but not anything that has an icon (1Password and others will load icons and pass them to us, but we don't load any icons).

We would need to convert the favicons into NativeImage format (something I'm not sure that we have done yet in our code). Just a heads up- doing this will break related webdriver tests

@bsclifton

This comment has been minimized.

Copy link
Member Author

bsclifton commented Sep 1, 2017

@alexwykoff related tracking issue:

Convert React ContextMenu items to native context menu #8641

@alexwykoff alexwykoff modified the milestones: 1.0.0, Backlog Nov 1, 2017

@srirambv

This comment has been minimized.

Copy link
Collaborator

srirambv commented Dec 8, 2017

@eljuno

This comment has been minimized.

@eljuno

This comment has been minimized.

@eljuno

This comment has been minimized.

Copy link
Contributor

eljuno commented Feb 20, 2018

+1 from community https://community.brave.com/t/bookmark-bug-unseen-here/16440?u=eljuno

The bookmarks is not showing properly on the right side

@eljuno

This comment has been minimized.

Copy link
Contributor

eljuno commented Jun 27, 2018

@srirambv

This comment has been minimized.

Copy link
Collaborator

srirambv commented Jun 27, 2018

@eljuno Yes this will be fixed by brave-core. @bsclifton this issue can be closed as its out-of-box fix on brave-core.

@srirambv srirambv removed this from the Triage Backlog milestone Jun 27, 2018

@srirambv srirambv added the wontfix label Jun 27, 2018

@JamborJan

This comment has been minimized.

Copy link

JamborJan commented Jul 2, 2018

From my point of view it is not a good thing to close an issue with a "wontfix" without pointing to the solution. There is no issue "out-of-box fix", the latest version of brave doesn't solve the problem. Users are not able to check the status of the problem. Just saying.

@bsclifton

This comment has been minimized.

Copy link
Member Author

bsclifton commented Jul 2, 2018

@JamborJan the solution is Brave Core which you can find here:
https://github.com/brave/brave-browser

Unfortunately, there are no public binaries currently available... but we should have some available within the next month or two. If you wanted to try it yourself, you can compile from source. This issue is closed as wontfix because we will not be fixing it with our current codebase (which is based on Muon, a fork of Electron)

@bsclifton

This comment has been minimized.

Copy link
Member Author

bsclifton commented Jul 2, 2018

Here's a screenshot from the current live build of Brave Core where the issue is fixed:
screen shot 2018-07-01 at 10 32 40 pm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.