Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Provide an option to disable "Top Sites" in autocomplete #4977

Closed
luixxiul opened this issue Oct 20, 2016 · 5 comments
Closed

Provide an option to disable "Top Sites" in autocomplete #4977

luixxiul opened this issue Oct 20, 2016 · 5 comments
Assignees
@luixxiul
Labels
feature/autocomplete feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include settings suggestion
Milestone
0.18.x Release

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Oct 20, 2016 •
edited

Test plan

#9063 (comment)

Expected behavior: Provide options to disable show Top Site and Brave Pages in "Search Bar Options" on about:preferences#search

screenshot 2016-10-20 13 33 39
@luixxiul luixxiul added this to the 0.12.9dev milestone Oct 30, 2016
@bsclifton
Copy link
Member

Removing this from the milestone; let's work with @bradleyrichter or @bbondy if we want to reassign it into a milestone

@bsclifton bsclifton removed this from the 0.12.9dev milestone Nov 8, 2016
@srirambv
Copy link
Collaborator

+1 from community https://community.brave.com/t/disable-top-sites-in-url-bar/930

@bradleyrichter
Copy link
Contributor

we just need to provide one more toggle here:

image

"Show top site matches"

@luixxiul luixxiul added this to the Backlog milestone Jan 31, 2017
@bsclifton bsclifton changed the title Provide an option to disable show Top Sites and Brave Pages Provide an option to disable show Top Sites Mar 16, 2017
@bsclifton
Copy link
Member

bsclifton commented Mar 16, 2017 •
edited

preloaded site complaints captured here with #7655 and #5892; the behavior will be resolved with #7717

Let's use this issue to discuss a preference for turning off the "Top Sites" results

edit: you may notice the confusion I had; this issue captures the autocomplete results, I'll make a separate one for the icons on new tab page (which are also called "Top Sites")

@bsclifton bsclifton changed the title Provide an option to disable show Top Sites Provide an option to disable Top Sites Mar 16, 2017
@bsclifton bsclifton changed the title Provide an option to disable Top Sites Provide an option to disable "Top Sites" in autocomplete Mar 16, 2017
@ayumi
Copy link
Contributor

ayumi commented May 2, 2017

+1

@luixxiul luixxiul self-assigned this May 25, 2017
@luixxiul luixxiul modified the milestones: 0.16.100, Backlog May 25, 2017
@luixxiul luixxiul mentioned this issue May 26, 2017
Merged
7 tasks
@bbondy bbondy modified the milestones: 0.16.200, 0.16.100 May 26, 2017
This was referenced Jul 24, 2017
Closed
Closed
This was referenced Jul 24, 2017
Closed
Closed
@luixxiul luixxiul mentioned this issue Jul 26, 2017
Closed
44 tasks
This was referenced Jul 26, 2017
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Jul 27, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
feature/autocomplete feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include settings suggestion
Projects
None yet
Milestone
0.18.x Release
Development

No branches or pull requests
8 participants
@ayumi @bbondy @luixxiul @bsclifton @bradleyrichter @srirambv @cndouglas @LaurenWags