This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDevtools warning of unknown prop #5345
Closed
Comments
|
Doh! This is my fault, I introduced this specific one in #5173 (https://github.com/brave/browser-laptop/blame/svg-conversion/js/components/tabsToolbar.js#L15) It's resolved in that PR. Closing this issue as the bug won't make it to master. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Did you search for similar issues before submitting this one?
Yes.
Describe the issue you encountered:
On current master with devtools open there is a warning about us using l10nid as a prop on native elements such as span and div. This probably comes from refactors as we've switched from a custom element to a standard one.
Expected behavior:
All standard elements should get data-l10n-id's instead of l10nid
Platform (Win7, 8, 10? macOS? Linux distro?):
macOS
Brave Version:
Building in development mode.
Steps to reproduce:
Screenshot if needed: