Skip to content
This repository has been archived by the owner. It is now read-only.

Devtools warning of unknown prop #5345

Closed
jkup opened this issue Nov 2, 2016 · 1 comment
Closed

Devtools warning of unknown prop #5345

jkup opened this issue Nov 2, 2016 · 1 comment
Assignees

Comments

@jkup
Copy link
Contributor

@jkup jkup commented Nov 2, 2016

Did you search for similar issues before submitting this one?
Yes.

Describe the issue you encountered:
On current master with devtools open there is a warning about us using l10nid as a prop on native elements such as span and div. This probably comes from refactors as we've switched from a custom element to a standard one.

Expected behavior:

All standard elements should get data-l10n-id's instead of l10nid

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS

  • Brave Version:
    Building in development mode.

  • Steps to reproduce:

    1. Pull Master
    2. npm watch and start
    3. open the developer console (shift+f8)
  • Screenshot if needed:

screen shot 2016-11-01 at 11 58 23 pm

  • Any related issues:
@jkup jkup added this to the 0.12.9dev milestone Nov 2, 2016
@jkup jkup self-assigned this Nov 2, 2016
@jkup jkup removed this from the 0.12.9dev milestone Nov 2, 2016
@jkup
Copy link
Contributor Author

@jkup jkup commented Nov 2, 2016

Doh! This is my fault, I introduced this specific one in #5173 (https://github.com/brave/browser-laptop/blame/svg-conversion/js/components/tabsToolbar.js#L15)

It's resolved in that PR. Closing this issue as the bug won't make it to master.

@jkup jkup closed this Nov 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.