Skip to content
This repository has been archived by the owner. It is now read-only.

Regression : Changing the number of visits is clearing the ledger site list #5397

Closed
alexwykoff opened this issue Nov 4, 2016 · 2 comments
Closed

Comments

@alexwykoff
Copy link
Contributor

@alexwykoff alexwykoff commented Nov 4, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
When changing the advanced setting to change the number of visits, my ledger listing of sites visited was cleared.

Expected behavior:
If a site met the prior requirements and we have relaxed the constraints (less visits, less time) they should persist.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Tested on OS X

  • Brave Version:
    0.12.8 RC1

  • Steps to reproduce:

    1. Visit some sites and have them on the ledger list.
    2. Change the advanced setting from 5 visits to 2.
    3. Observer the ledger list.
  • Screenshot if needed:

  • Any related issues:

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Nov 4, 2016

Its covered in #5200 which is marked as 0.12.9

@bbondy
Copy link
Member

@bbondy bbondy commented Nov 4, 2016

marking as dupe of that and removing from 0.12.8.

@bbondy bbondy closed this Nov 4, 2016
@bbondy bbondy added the duplicate label Nov 4, 2016
@bbondy bbondy removed this from the 0.12.8dev milestone Nov 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.