Skip to content
This repository has been archived by the owner. It is now read-only.

Update noScript string for Preferences page only #5420

Closed
jkup opened this issue Nov 5, 2016 · 4 comments
Closed

Update noScript string for Preferences page only #5420

jkup opened this issue Nov 5, 2016 · 4 comments
Assignees

Comments

@jkup
Copy link
Contributor

@jkup jkup commented Nov 5, 2016

re: @bradleyrichter's request the preferences page "Block Scripts" string should be changed to "Block Scripts (will break many sites)" but the shields panel should remain "Block Scripts"

@jkup jkup added the settings label Nov 5, 2016
@jkup jkup added this to the 0.12.9dev milestone Nov 5, 2016
@jkup jkup self-assigned this Nov 5, 2016
@jkup
Copy link
Contributor Author

@jkup jkup commented Nov 5, 2016

This is now going into a ticket with a lot of other string changes.

@jkup jkup closed this Nov 5, 2016
@jkup jkup removed this from the 0.12.9dev milestone Nov 5, 2016
@jkup jkup removed the settings label Nov 5, 2016
@bsclifton
Copy link
Member

@bsclifton bsclifton commented Nov 6, 2016

@jkup can you link to the ticket this was added to?

@jkup
Copy link
Contributor Author

@jkup jkup commented Nov 6, 2016

@bradleyrichter had asked me about fixing this yesterday and then suggested that I just show him how bc he has a ticket he's working on with multiple string changes.

@bradleyrichter can you put the ticket number in here?

@bradleyrichter
Copy link
Contributor

@bradleyrichter bradleyrichter commented Nov 6, 2016

Yep. #5421

On Nov 6, 2016, at 11:43 AM, Jon Kuperman notifications@github.com wrote:

@bradleyrichter had asked me about fixing this yesterday and then suggested that I just show him how bc he has a ticket he's working on with multiple string changes.

@bradleyrichter can you put the ticket number in here?


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.