Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upreplacement icons for private browsing tab icon #547
Comments
|
Surely the eyeball icon makes me psychedelic feeling.. |
|
How about trying Kinda small, but not too bad. I think this is still better than the eyeball. |
|
Shipped |
|
No |
|
Ah, quite right. My bad. |
|
@bradleyrichter do you have any suggestion in FA? |
|
Ironically I tried the little burgler today. Still needs sunglasses. Maybe @jkup can help me use a custom favicon of the sunglasses? Also, we should make an about page for that tab as well.
|
|
@bradleyrichter have you made the icon already? |
|
@luixxiul I have it in the new sprite bitmaps but we will need to also implement the threshold color change when used in the tab. |
|
moved to 0.14.1 for this reasoning: #7943 (comment) |
|
New tab styles combined with purple tab color for private non-selected creates a usability issue. Can't tell which tab is active at smaller sizes.
It would be nice to cherry pick this tab color fix.
… On Mar 29, 2017, at 5:51 AM, Brian R. Bondy ***@***.***> wrote:
moved to 0.14.1 for this reasoning: #7943 (comment)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|

Test plan
Covered by #7943
Original issue description
@bbondy These will be used in iOS. Please convert current font awesome eyeball to these sunglasses.