Skip to content
This repository has been archived by the owner. It is now read-only.

Icon alignment on mouse hover is not proper #5566

Closed
srirambv opened this issue Nov 11, 2016 · 4 comments
Closed

Icon alignment on mouse hover is not proper #5566

srirambv opened this issue Nov 11, 2016 · 4 comments
Assignees
Milestone

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Nov 11, 2016

Icon alignment is wrong on mouse hover

Build - Master

image

cc: @jkup @bsclifton @bradleyrichter

@bradleyrichter
Copy link
Contributor

@bradleyrichter bradleyrichter commented Nov 12, 2016

since all of this alignment is perfect on mac, we MUST make windows-specific additions to the CSS then.

@bsclifton
Copy link
Member

@bsclifton bsclifton commented Nov 12, 2016

Issue caused by something in #5526

Can be fixed by updating/creating Windows specific CSS selectors here:

.platform--win32 {

@bbondy
Copy link
Member

@bbondy bbondy commented Nov 14, 2016

screenshot 2016-11-13 23 20 06

screenshot 2016-11-13 23 20 10

@bbondy
Copy link
Member

@bbondy bbondy commented Nov 14, 2016

pushing a commit with that ^

@bbondy bbondy assigned bbondy and unassigned jkup Nov 14, 2016
@bbondy bbondy closed this in 845116d Nov 14, 2016
bbondy added a commit that referenced this issue Nov 14, 2016
Fix #5566

Just tweaking values since it was like that already and I want to do new builds for testing, but it would definitely be better if this used auto for automatically positioning these icons

Auditors: @bsclifton

Screenshot is in the issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.