This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove error message for payments #5606
Closed
Labels
Milestone
Comments
|
I agree with the "This Site" part. I think a more generic error message would be great. As for the disabled fields.. is there a situation you can get into where your wallet is ready and you already have a monthly budget set but we just can't get your balance right now? I only worry about making the entire feature look disabled when really we're just offline so can't get a real time balance. |
Merged
This was referenced Nov 21, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
This siteUsers will question Which site??Wouldn't it be simpler to just say Brave Wallet can't be reached, Please check your Internet connection. instead saying an error occurred and showing DNS error message
Also monthly budget dropdown should be disabled and status shouldn't show Your Wallet is ready! when it can't retrieve info. Status should be hidden when the wallet balance is not shown
cc: @mrose17 @bradleyrichter @ayumi
#4920