Skip to content
This repository has been archived by the owner. It is now read-only.

Improve error message for payments #5606

Closed
srirambv opened this issue Nov 14, 2016 · 1 comment
Closed

Improve error message for payments #5606

srirambv opened this issue Nov 14, 2016 · 1 comment

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Nov 14, 2016

image

This site Users will question Which site??

Wouldn't it be simpler to just say Brave Wallet can't be reached, Please check your Internet connection. instead saying an error occurred and showing DNS error message

Also monthly budget dropdown should be disabled and status shouldn't show Your Wallet is ready! when it can't retrieve info. Status should be hidden when the wallet balance is not shown

cc: @mrose17 @bradleyrichter @ayumi

@mrose17 mrose17 self-assigned this Nov 15, 2016
@mrose17 mrose17 added this to the 0.12.10 release milestone Nov 15, 2016
@jkup
Copy link
Contributor

@jkup jkup commented Nov 15, 2016

I agree with the "This Site" part. I think a more generic error message would be great. As for the disabled fields.. is there a situation you can get into where your wallet is ready and you already have a monthly budget set but we just can't get your balance right now?

I only worry about making the entire feature look disabled when really we're just offline so can't get a real time balance.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.