Skip to content
This repository has been archived by the owner. It is now read-only.

bookmark should appear soon after being added on about:bookmarks #5628

Closed
luixxiul opened this issue Nov 15, 2016 · 2 comments
Closed

bookmark should appear soon after being added on about:bookmarks #5628

luixxiul opened this issue Nov 15, 2016 · 2 comments

Comments

@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Nov 15, 2016

Describe the issue you encountered: Bookmark manager needs reopening to confirm that a bookmark was correctly added there. I noticed it when I was checking #5445 was merged properly

Expected behavior: bookmarks should appear soon after being added on about:bookmarks

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10

  • Brave Version: 0.12.9 RC1

  • Steps to reproduce:

    1. Open about:bookmarks
    2. Bookmark https://clifton.io by clicking the star icon on the table
    3. Nothing seems to have been added
    4. Close the bookmarks manager
    5. Reopen it
    6. See the most below line
  • Screenshot if needed:

  • Any related issues:

@luixxiul luixxiul added this to the 0.12.10 release milestone Nov 15, 2016
@luixxiul
Copy link
Contributor Author

@luixxiul luixxiul commented Nov 15, 2016

I cannot reproduce it. There could be a race condition.

@luixxiul luixxiul removed this from the 0.12.10 release milestone Nov 15, 2016
@luixxiul luixxiul added the needs-info label Nov 15, 2016
@NejcZdovc
Copy link
Member

@NejcZdovc NejcZdovc commented Jul 20, 2017

I think this is fixed already.

@NejcZdovc NejcZdovc closed this Jul 20, 2017
@luixxiul luixxiul removed the needs-info label Jul 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.