Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

about:newtab appears on the top sites list #5638

Closed
luixxiul opened this issue Nov 15, 2016 · 5 comments
Closed

about:newtab appears on the top sites list #5638

luixxiul opened this issue Nov 15, 2016 · 5 comments
Assignees
@cezaraugusto
Labels
bug feature/newtab QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.13.0

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered: about:newtab appears on the top sites list

Expected behavior: about pages should be excluded from the top sites list

  • Platform (Win7, 8, 10? macOS? Linux distro?): macOS

  • Brave Version: master branch

  • Any related issues:
@luixxiul luixxiul added this to the 0.12.10 release milestone Nov 15, 2016
@bbondy
Copy link
Member

bbondy commented Nov 17, 2016

@luixxiul which top site list do you mean? Do you mean urlbar suggestions or the top sites on the new tab page? Could you give steps to reproduce please?

@bbondy
Copy link
Member

bbondy commented Nov 17, 2016

Moving this to 0.12.11 I don't see how to repro, I opened a new tab, and then another new tab, but no tile is shown on the about:newtab page for about:newtab.

@bbondy bbondy modified the milestones: 0.12.11, 0.12.10 release Nov 17, 2016
@luixxiul
Copy link
Contributor Author

I meant one on the new tab page.

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Nov 18, 2016 •
edited

Reproducible by bookmarking new tab page.

@cezaraugusto cezaraugusto mentioned this issue Nov 18, 2016
Merged
4 tasks
This was referenced Dec 11, 2016
Closed
Closed
This was referenced Dec 20, 2016
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Dec 20, 2016
Closed
@luixxiul
Copy link
Contributor Author

Test plan specified here: #5728 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cezaraugusto cezaraugusto

Labels
bug feature/newtab QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.13.0
Development

No branches or pull requests
4 participants
@bbondy @luixxiul @cezaraugusto @srirambv