Skip to content
This repository has been archived by the owner. It is now read-only.

Creating a bookmark without http/https suffix causes a blank page favicon #5713

Closed
srirambv opened this issue Nov 17, 2016 · 1 comment
Closed

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Nov 17, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
Users don't tend to add http/https suffix while manually adding a bookmark. Would simply type the domain name and add a bookmark. Adding like this causes a blank page favicon to the bookmark and doesn't change even after visiting the bookmarked link.

Expected behavior:
Should auto prefix http/https and update the bookmarks when visited, also favicons should be created after suffixing http/https to the bookmark upon visiting them

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version:
    master branch

  • Steps to reproduce:

    1. Add a bookmark manually in about:bookmarks by clicking the star+ icon
    2. In location enter the domain name without the http/https suffix (eg: brave.com)
    3. Added bookmark shows a blank page favicon, visiting the site by clicking the bookmark doesn't update the favicon
    4. Add a new bookmark with a trailing / after the domain name (eg: apple.com/)
    5. Visit the bookmark added in step 4, doesn't show the orange bookmark icon in the URL bar
  • Screenshot if needed:
    blankfavicon

  • Any related issues:
    #4860

    cc: @bsclifton

@srirambv srirambv added this to the 1.1.0 milestone Nov 17, 2016
@srirambv
Copy link
Collaborator Author

@srirambv srirambv commented Nov 17, 2016

Adding 1.1.0 as milestone, Please change if required.

@luixxiul luixxiul added bug needs-triage and removed suggestion labels Jun 4, 2017
@alexwykoff alexwykoff modified the milestones: 1.1.0, Backlog Nov 1, 2017
@cezaraugusto cezaraugusto modified the milestone: Triage Backlog Nov 8, 2017
@bsclifton bsclifton removed this from the Triage Backlog milestone Nov 8, 2017
@bsclifton bsclifton added this to the Backlog (Prioritized) milestone Nov 22, 2017
@bsclifton bsclifton removed this from the Backlog (Prioritized) milestone Aug 25, 2018
@bsclifton bsclifton closed this Aug 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.