Skip to content
This repository has been archived by the owner. It is now read-only.

Brave wallet recovery failure message should be localizable #5806

Closed
luixxiul opened this issue Nov 23, 2016 · 3 comments
Closed

Brave wallet recovery failure message should be localizable #5806

luixxiul opened this issue Nov 23, 2016 · 3 comments

Comments

@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Nov 23, 2016

Describe the issue you encountered:

<h1>Recovery failed</h1>
<p className='spaceAround'>Please re-enter keys or try different keys.</p>
is hardcoded and cannot be localized.

screenshot 2016-11-23 13 38 46

Expected behavior: It should be localizable

  • Brave Version: master branch

  • Any related issues:

Test plan

#4720 (comment)

@luixxiul luixxiul added this to the 0.13.0 milestone Nov 23, 2016
@luixxiul
Copy link
Contributor Author

@luixxiul luixxiul commented Nov 23, 2016

Also

<h1>Success!</h1>

@bsclifton bsclifton self-assigned this Nov 29, 2016
@bbondy bbondy modified the milestones: 0.13.1, 0.13.0 Dec 1, 2016
@bsclifton
Copy link
Member

@bsclifton bsclifton commented Dec 6, 2016

@luixxiul this might be a good issue for you to solve, since you're already in there 😄 Please feel free to assign yourself

@bsclifton
Copy link
Member

@bsclifton bsclifton commented Dec 28, 2016

Removed ledger label; see the commit in first post for the two strings which need to be localized 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

5 participants
You can’t perform that action at this time.