Skip to content
This repository has been archived by the owner. It is now read-only.

/ browser-laptop Archived

Missing l10n strings - Simplified Chinese #6309

Closed
alexwykoff opened this issue Dec 20, 2016 · 4 comments
Closed

Missing l10n strings - Simplified Chinese #6309

alexwykoff opened this issue Dec 20, 2016 · 4 comments
Labels
addressed-with-brave-core l10n wontfix

Comments

@alexwykoff
Copy link
Contributor

@alexwykoff alexwykoff commented Dec 20, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
While testing the application a number of missing strings were discovered.

Expected behavior:
Language coverage should have parity.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Tested on OS X

  • Brave Version:
    0.13.0 Preview 5

  • Steps to reproduce:

    1. Open preferences in 0.13.0, select Chinese.
    2. Restart the app.

  • Screenshot if needed:

screen shot 2016-12-19 at 8 18 26 pm

screen shot 2016-12-19 at 8 18 37 pm

screen shot 2016-12-19 at 8 18 43 pm

screen shot 2016-12-19 at 8 18 49 pm

screen shot 2016-12-19 at 8 19 03 pm

screen shot 2016-12-19 at 8 19 09 pm

screen shot 2016-12-19 at 8 19 20 pm

screen shot 2016-12-19 at 8 19 37 pm

screen shot 2016-12-19 at 8 19 43 pm

screen shot 2016-12-19 at 8 19 48 pm

screen shot 2016-12-19 at 8 19 55 pm

  • Any related issues:
@alexwykoff alexwykoff added this to the 1.0.0 milestone Dec 20, 2016
@luixxiul luixxiul added the l10n label Dec 20, 2016
@bbondy
Copy link
Member

@bbondy bbondy commented Dec 21, 2016

It'd help to identify if these strings are not available yet for translation, or if they just haven't been translated. I'm assuming the former.
You can tell by cloning the repo and git grep "string to search" to see if it's in there.
@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Dec 21, 2016

I confirmed "5seconds" and "8views" on Brave payments 的高級設置 were not localizable. the others are just missing localized strings.
@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Dec 21, 2016

I have noticed other strings on about:preferences#payments which could not localized here: #5806 fwiw
@luixxiul luixxiul mentioned this issue Dec 21, 2016
Closed
@alexwykoff
Copy link
Contributor Author

@alexwykoff alexwykoff commented Mar 2, 2017

0.13.5 rc 1 update, I will search the properties files to make sure the strings are accounted for and if not, open new tracking issues per feature:

screen shot 2017-03-02 at 9 07 59 am

screen shot 2017-03-02 at 9 06 52 am

screen shot 2017-03-02 at 9 06 42 am

screen shot 2017-03-02 at 9 06 36 am

screen shot 2017-03-02 at 9 06 31 am

screen shot 2017-03-02 at 9 06 01 am

screen shot 2017-03-02 at 9 05 53 am

screen shot 2017-03-02 at 9 05 46 am

screen shot 2017-03-02 at 9 05 39 am

screen shot 2017-03-02 at 9 08 13 am

screen shot 2017-03-02 at 9 05 26 am

screen shot 2017-03-02 at 9 08 03 am
@srirambv srirambv mentioned this issue Mar 15, 2017
Closed
@alexwykoff alexwykoff modified the milestones: 1.0.0, Backlog Nov 1, 2017
@bsclifton bsclifton closed this Oct 1, 2018
@bsclifton bsclifton added the wontfix label Oct 1, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Oct 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
addressed-with-brave-core l10n wontfix
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
@bbondy @alexwykoff @luixxiul @bsclifton
You can’t perform that action at this time.