Skip to content
This repository has been archived by the owner. It is now read-only.

IME for Japanese freezes webview inside a tab #6463

Closed
luixxiul opened this issue Dec 30, 2016 · 19 comments
Closed

IME for Japanese freezes webview inside a tab #6463

luixxiul opened this issue Dec 30, 2016 · 19 comments

Comments

@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Dec 30, 2016

Describe the issue you encountered:
If you enable IME for Japanese, hit some keys inside a input form on a page and the space key to select conversion candidates, the tab (under webview) freezes and accepts nothing until you close the tab.

Expected behavior:
It should not freeze

  • Platform (Win7, 8, 10? macOS? Linux distro?): macOS

  • Brave Version (revision SHA): 0c7a64d

  • Steps to reproduce:

    1. Enable Japanese IME following the instruction here: http://redcocoon.org/cab/mysoft.html
    2. Open https://github.com/brave/browser-laptop in a new tab
    3. Select the search input area on that page
    4. Hit a to input
    5. Hit the space key
    6. Hit the enter key
      Then the tab freezes; you can neither clear the character nor click any links
  • Any related issues:

This could not be confirmed on 0.12 series. I think this might be related with cr54 update.

@luixxiul luixxiul added this to the 0.13.0 milestone Dec 30, 2016
@luixxiul
Copy link
Contributor Author

@luixxiul luixxiul commented Dec 30, 2016

Even pasting a Japanese character into the input area freezes tab.

@bbondy
Copy link
Member

@bbondy bbondy commented Dec 30, 2016

Perhaps it is session store related? For me it is working correctly (I think, it's the first time I tried it). It does not freeze the tab. Maybe you can send me your session store file?

screenshot 2016-12-30 11 03 41

@luixxiul
Copy link
Contributor Author

@luixxiul luixxiul commented Dec 30, 2016

Please open https://github.com/brave/browser-laptop in a new tab and select the search input area here:

clipboard01

Also updated the STR.

@bbondy
Copy link
Member

@bbondy bbondy commented Dec 30, 2016

I wonder if this could be fixed with ICU, I think we should hold on investigating until we confirm after the ICU fix.

@bbondy
Copy link
Member

@bbondy bbondy commented Dec 30, 2016

I did reproduce successfully though, thanks for the updated steps.

@luixxiul
Copy link
Contributor Author

@luixxiul luixxiul commented Dec 31, 2016

I doubt if this is related with IME because the tab also freezes after clicking "Edit Post" of a post on your facebook timeline.

I'm not quite sure if this is the same issue though.

@luixxiul
Copy link
Contributor Author

@luixxiul luixxiul commented Jan 15, 2017

@bbondy can this be closed to based on the ICU change?

@bbondy
Copy link
Member

@bbondy bbondy commented Jan 15, 2017

It can be closed if it is working, preview 8 which is available has the ICU fix.

@bbondy
Copy link
Member

@bbondy bbondy commented Jan 15, 2017

Seems to be working for me now, please re-open if you find it doesn't work.

@luixxiul
Copy link
Contributor Author

@luixxiul luixxiul commented Jan 15, 2017

It seems it has not been fixed completely.

ime

rev 567bd73
Muon 2.0.10

@luixxiul luixxiul reopened this Jan 15, 2017
@bbondy
Copy link
Member

@bbondy bbondy commented Jan 15, 2017

Could you update new steps to follow in the first comment, because the ones there that I followed worked now.

@darkdh darkdh self-assigned this Jan 16, 2017
@darkdh
Copy link
Member

@darkdh darkdh commented Jan 16, 2017

@luixxiul the gif you pasted doesn't look like native macOS Japanese input source
The picture below is what I saw following the Enable Japanese IME following the instruction here: http://redcocoon.org/cab/mysoft.html
screen shot 2017-01-16 at 10 46 56

@luixxiul
Copy link
Contributor Author

@luixxiul luixxiul commented Jan 16, 2017

@darkdh it's Google IME

@darkdh
Copy link
Member

@darkdh darkdh commented Jan 16, 2017

still can't reproduce on

ynzupus0nt

rev: 9a98903
Muon: 2.0.11

@luixxiul
Copy link
Contributor Author

@luixxiul luixxiul commented Jan 16, 2017

@darkdh did you hit enter? the 5th 6th step

@luixxiul
Copy link
Contributor Author

@luixxiul luixxiul commented Jan 16, 2017

Ah I'm guessing the issue was resolved with Muon 2.0.11

@darkdh
Copy link
Member

@darkdh darkdh commented Jan 16, 2017

yeah, I did. updated with displaying pressed key version
k5csgkr2vt

@luixxiul
Copy link
Contributor Author

@luixxiul luixxiul commented Jan 16, 2017

Sweet :-D

@luixxiul luixxiul closed this Jan 16, 2017
@luixxiul
Copy link
Contributor Author

@luixxiul luixxiul commented Jan 16, 2017

Test plan:

Enable Japanese IME following the instruction here: http://redcocoon.org/cab/mysoft.html
Open https://github.com/brave/browser-laptop in a new tab
Select the search input area on that page
Hit a to input
Hit the space key
Hit the enter key

Then the tab should NOT freezes

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.