Skip to content
This repository has been archived by the owner. It is now read-only.

/ browser-laptop Archived

“Brave installer for OS X has grown by 20 Mb" #6658

Closed
alexwykoff opened this issue Jan 16, 2017 · 2 comments
Closed

“Brave installer for OS X has grown by 20 Mb" #6658

alexwykoff opened this issue Jan 16, 2017 · 2 comments
Assignees
@bbondy
Labels
QA/no-qa-needed release-notes/exclude
Milestone
0.13.0

Comments

@alexwykoff
Copy link
Contributor

@alexwykoff alexwykoff commented Jan 16, 2017 •
edited

The Brave installer (0.13.0 Preview 8) for OS X has grown from approximately 80Mb to over 100Mb.

Our MO is to investigate when installers grow by a significant amount.
@alexwykoff alexwykoff added this to the 0.13.0 milestone Jan 16, 2017
bbondy added a commit that referenced this issue Jan 17, 2017
@bbondy
Trim down node_modules
Verified
This commit was signed with a verified signature.
bbondy Brian R. Bondy
GPG key ID: 52EE2E5BD38B6A2D Learn about signing commits
Loading status checks…
3fb5bff 
This was done in the context of #6658

Auditors: @aekeus
@bbondy
Copy link
Member

@bbondy bbondy commented Jan 17, 2017

I looked into this but unfortunately there's not much we can do about it currently. It's just us including more of chromium. I shed off a couple MB for obvious node_module stuff we don't need at least in the context of this.
@bbondy bbondy closed this Jan 17, 2017
@bbondy
Copy link
Member

@bbondy bbondy commented Jan 17, 2017

Leaving this in the milestone since code landed for it.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbondy bbondy

Labels
QA/no-qa-needed release-notes/exclude
Projects
None yet
Milestone
  0.13.0
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@bbondy @alexwykoff
You can’t perform that action at this time.