Skip to content
This repository has been archived by the owner. It is now read-only.

/ browser-laptop Archived

Setting clear browser data on close doesn't clear history entry after restart #6673

Closed
srirambv opened this issue Jan 16, 2017 · 1 comment
Closed

Setting clear browser data on close doesn't clear history entry after restart #6673

srirambv opened this issue Jan 16, 2017 · 1 comment
Assignees
@darkdh
Labels
QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified bug feature/history release-notes/exclude
Milestone
0.13.0

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Jan 16, 2017 •
edited by luixxiul

Test plan:

  1. Make sure there are some history and new tab tiles
  2. Choose clear "Browsing History" on close in about:preferences#security
  3. Restart Brave
  4. There shouldn't be any history in about:history and tiles in about:newtab

Did you search for similar issues before submitting this one?
Yes, Didn't find similar one

Describe the issue you encountered:
Setting clear browser data on close doesn't clear history entry after restart

Expected behavior:
Should clear history entries upon restart when clear browser data switch is turned on

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.13.0
    rev dc4f0fd
    Verified on 0.12.15 works fine. Not checked on previous 0.13.0 builds

  • Steps to reproduce:

    1. Clear browser history
    2. Set Browsing history. Cached images and files, All site cookies under security to clear upon closing Brave
    3. Visit any site to add a history entry in about:history
    4. Close and restart the browser
    5. History entry from step 3 is still shown even though clear browsing data is set to clear upon close

  • Screenshot if needed:
    history

  • Any related issues:
@srirambv srirambv added this to the 0.13.0 milestone Jan 16, 2017
@srirambv srirambv added the OS/Windows label Jan 16, 2017
@darkdh darkdh self-assigned this Jan 16, 2017
@darkdh darkdh removed the OS/Windows label Jan 16, 2017
darkdh added a commit to darkdh/browser-laptop that referenced this issue Jan 16, 2017
@darkdh
Clean [about, newtab] and [about, history] when clear on close
Verified
This commit was signed with a verified signature.
darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits
ef4db76 
see APP_CLEAR_HISTORY in appStore.js

fix brave#6673

Auditors: @bbondy, @bsclifton

Test Plan:
1. Make sure there are some history and new tab tiles
2. Choose clear "Browsing History" on close in about:preferences#security
3. Restart Brave
4. There shouldn't be any history in about:history and tiles in about:newtab
@darkdh darkdh mentioned this issue Jan 16, 2017
Merged
0 of 4 tasks complete
@bbondy bbondy closed this in #6678 Jan 16, 2017
@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Jan 16, 2017

Test plan: #6678 (comment)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified bug feature/history release-notes/exclude
Projects
None yet
Milestone
  0.13.0
Linked pull requests

Successfully merging a pull request may close this issue.

Clean [about, newtab] and [about, history] when clear on close
3 participants
@luixxiul @darkdh @srirambv
You can’t perform that action at this time.