Skip to content
This repository has been archived by the owner. It is now read-only.

/ browser-laptop Archived

Opening preferences from kabob puts tab in background #6791

Closed
bsclifton opened this issue Jan 21, 2017 · 6 comments
Closed

Opening preferences from kabob puts tab in background #6791

bsclifton opened this issue Jan 21, 2017 · 6 comments
Labels
QA/checked-Win32 QA/test-plan-specified bug release-notes/exclude
Milestone
0.13.0

Comments

@bsclifton
Copy link
Member

@bsclifton bsclifton commented Jan 21, 2017

  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:
    Opening "Settings" (preferences on macOS) from the kabob menu will sometimes background the tab. Here's a demo:
    prefs

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    os.platform win32
    os.release 10.0.14393
    os.arch x64

  • Brave Version (revision SHA):
    Brave 0.13.0 (release candidate 4)
    rev 40dffe8
    Muon 2.0.13
    libchromiumcontent 54.0.2840.100
    V8 5.4.500.41
    Node.js 7.0.0
    Update Channel dev

  • Steps to reproduce:

  1. Launch Brave on Windows 10 x64 using the desktop shortcut
  2. visit brave.com
  1. close all the other tabs (especially preferences)
  2. use kabob / hamburger menu to pick settings
  3. make a very sad face because tab opened, but it opened like you did it with Ctrl + click or cmd+click (backgrounded it)

  • Actual result:
    Sometimes (many times), preferences will load in the background (as if you opened it with ctrl + click or cmd+click)

  • Expected result:
    Tab should always open in the foreground

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?

  • Is this an issue in the currently released version?
    no

  • Can this issue be consistently reproduced?
    yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:
@bsclifton bsclifton added the bug label Jan 21, 2017
@bsclifton bsclifton added this to the 0.13.1 milestone Jan 21, 2017
@bsclifton
Copy link
Member Author

@bsclifton bsclifton commented Jan 21, 2017

@aekeus was able to reproduce on macOS with the following steps:

  • close Brave
  • open Brave
  • select Kabob > Preferences
  • tab goes to background
@bbondy bbondy modified the milestones: 0.13.0, 0.13.1 Jan 21, 2017
@srirambv
Copy link
Collaborator

@srirambv srirambv commented Jan 21, 2017

Its not just on opening preference page from kabob menu. Even opening a new tab causes it to go background

tabswitch
@bbondy bbondy closed this in d4f79be Jan 21, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Jan 23, 2017
@bbondy @NejcZdovc
Only set active tab when value changes
Unverified
This user has not uploaded their public key yet.
GPG key ID: 584931E990AC6064 Learn about signing commits
2d3632c 
Fix brave#6791

Auditors: @bridiver

I think the real raeson this is happening is because of the async updating which we'll be removing, but is too risky to do for 0.13.0.

I think this is probably better to do in general though anyway
@bridiver bridiver mentioned this issue Jan 26, 2017
Closed
@bridiver bridiver reopened this Jan 26, 2017
@bridiver
Copy link
Collaborator

@bridiver bridiver commented Jan 26, 2017

reopening after reverting aeab0bd
@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Jan 27, 2017 •
edited

I'm not sure if the issue was fixed:

rev 1ef3a56
Muon 2.0.17

about
@luixxiul luixxiul reopened this Jan 27, 2017
@bridiver
Copy link
Collaborator

@bridiver bridiver commented Jan 27, 2017

this is still happening, but very infrequently. I don't think we should block on it
bridiver added a commit that referenced this issue Jan 27, 2017
@bridiver
don’t call doAction inside doAction because it has the potential to l…
Loading status checks…
7968884 
…ose updates

fix #6791
@bridiver bridiver mentioned this issue Jan 27, 2017
Merged
4 of 4 tasks complete
bridiver added a commit that referenced this issue Jan 27, 2017
@bridiver
ensure that the menu close action happens after the click action
Loading status checks…
5f7891a 
fix #6791
@bbondy bbondy closed this in #6885 Jan 27, 2017
bbondy added a commit that referenced this issue Jan 27, 2017
@bridiver @bbondy
ensure that the menu close action happens after the click action
Verified
This commit was signed with a verified signature.
bbondy Brian R. Bondy
GPG key ID: 52EE2E5BD38B6A2D Learn about signing commits
Loading status checks…
8ca0127 
fix #6791
@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Jan 27, 2017

@bridiver thanks for taking this soon!
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
QA/checked-Win32 QA/test-plan-specified bug release-notes/exclude
Projects
None yet
Milestone
  0.13.0
Linked pull requests

Successfully merging a pull request may close this issue.

don’t call doAction inside doAction because it has the potential to l…
5 participants
@bridiver @bbondy @luixxiul @bsclifton @srirambv
You can’t perform that action at this time.