Skip to content
This repository has been archived by the owner. It is now read-only.

The blocked URL is attached to "about:safebrowsing#" #6797

Closed
luixxiul opened this issue Jan 21, 2017 · 5 comments
Closed

The blocked URL is attached to "about:safebrowsing#" #6797

luixxiul opened this issue Jan 21, 2017 · 5 comments

Comments

@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Jan 21, 2017

Describe the issue you encountered:
The blocked URL is attached to about:safebrowsing#

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10 32 bit

  • Brave Version (revision SHA): 0.13.0 RC4

  • Steps to reproduce:

    1. Open http://downloadme.org/
  • Actual result:
    clipboard01

  • Expected result:
    clipboard01

  • Will the steps above reproduce in a fresh profile?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Any related issues: #6318

b3c86d8#diff-8a9bac13ef6264feb2b6da7c18d86b3cR144

@luixxiul luixxiul added this to the 0.13.0 milestone Jan 21, 2017
@srirambv
Copy link
Collaborator

@srirambv srirambv commented Jan 21, 2017

I remember @diracdeltas had mentioned that it should just show as about:safebrowsing and not https://downloadme.org/.

The URL changes to https://downloadme.org if autohide URL bar is enabled.

@bbondy
Copy link
Member

@bbondy bbondy commented Jan 21, 2017

this is the new expected URL I think, at least it was an intentional change.
@diracdeltas please let us know if we can instead show the shortened URL in UI only, but not needed for this version so removing the milestone.

@bbondy bbondy removed this from the 0.13.0 milestone Jan 21, 2017
@luixxiul luixxiul added needs-info and removed regression bug labels Jan 21, 2017
@diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Jan 21, 2017

i think we can show the original url instead of about:safebrowsing

@luixxiul luixxiul removed the needs-info label Jan 21, 2017
@luixxiul
Copy link
Contributor Author

@luixxiul luixxiul commented May 28, 2017

I think the change works fine. wontfix?

@luixxiul luixxiul added the needs-info label May 28, 2017
@diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented May 28, 2017

agree

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.