Skip to content
This repository has been archived by the owner. It is now read-only.

/ browser-laptop Archived

facebook oauth is not working on zillow #6811

Closed
darkdh opened this issue Jan 22, 2017 · 6 comments
Closed

facebook oauth is not working on zillow #6811

darkdh opened this issue Jan 22, 2017 · 6 comments
Assignees
@darkdh
Labels
QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified bug regression release-notes/exclude
Milestone
0.13.0

Comments

@darkdh
Copy link
Member

@darkdh darkdh commented Jan 22, 2017 •
edited

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    oauth not work when you need credential from facebook

  • Platform (Win7, 8, 10? macOS? Linux distro?): macOS

  • Brave Version (revision SHA): 0.13.0 rc5

  • Steps to reproduce:

    1. Go to http://www.zillow.com/
    2. Click join/sign in
    3. Click connect with Facebook

  • Expected result
    I should be able let zillow access my Facebook credential

  • Actual result:

  1. First time click permission granted (the window should auto close)

screen shot 2017-01-22 at 22 26 44

2. After point2, click sign in from facebook (blank content)

screen shot 2017-01-22 at 22 24 06

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?

  • Is this an issue in the currently released version?

  • Can this issue be consistently reproduced?

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:
@darkdh darkdh added bug cr54 labels Jan 22, 2017
@darkdh darkdh added this to the 0.13.0 milestone Jan 22, 2017
@darkdh darkdh self-assigned this Jan 24, 2017
@bridiver bridiver added the regression label Jan 24, 2017
@diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Jan 24, 2017

I can repro this on airbnb.com (login with Google Account)
@darkdh
Copy link
Member Author

@darkdh darkdh commented Jan 24, 2017

feedly with (google, facebook), airbnb with (google, facebook) and zillow with google all work fine to me
@darkdh darkdh changed the title oauth is not working facebook oauth is not working on zillow Jan 24, 2017
darkdh added a commit to darkdh/browser-laptop that referenced this issue Jan 25, 2017
@darkdh
Check cookie exception before purging cookie request
Verified
This commit was signed with a verified signature.
darkdh Anthony Tseng
GPG key ID: E14094A20D3AAEEC Learn about signing commits
0e54c0d 
Add www.zillow.com to siteHack

fix brave#6811

Auditors: @bbondy, @bridiver

Test Plan:
1. Go to www.zillow.com
2. Login with facebook
@darkdh darkdh mentioned this issue Jan 25, 2017
Closed
4 of 4 tasks complete
@diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Jan 25, 2017

it's still broken on airbnb with google for me on a37f260 (RC6). clicking on 'login with google' pops up a window that never loads.

screen shot 2017-01-25 at 10 18 06 pm
@darkdh
Copy link
Member Author

@darkdh darkdh commented Jan 26, 2017

fixed in brave/muon@6cd5610
@darkdh darkdh closed this Jan 26, 2017
@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Jan 26, 2017

The link to facebook does not work unless the shield is down anyway.
@diracdeltas
Copy link
Member

@diracdeltas diracdeltas commented Jan 31, 2017

confirmed goog login on airbnb works in 0.13.0 release. 👍
@dmonay dmonay mentioned this issue Jun 13, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@darkdh darkdh

Labels
QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified bug regression release-notes/exclude
Projects
None yet
Milestone
  0.13.0
Linked pull requests

Successfully merging a pull request may close this issue.

Check cookie exception before purging cookie request
5 participants
@bridiver @diracdeltas @luixxiul @darkdh @srirambv
You can’t perform that action at this time.