Skip to content
This repository has been archived by the owner. It is now read-only.

Performance : 0.13.0 tab switching tracking issue #6835

Closed
alexwykoff opened this issue Jan 24, 2017 · 3 comments
Closed

Performance : 0.13.0 tab switching tracking issue #6835

alexwykoff opened this issue Jan 24, 2017 · 3 comments

Comments

@alexwykoff
Copy link
Contributor

@alexwykoff alexwykoff commented Jan 24, 2017

  • Did you search for similar issues before submitting this one?
    yes

  • Describe the issue you encountered:
    performance on tab switching appears to be slower

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    all, tests so far have focused on os x
    win coverage needed

  • Brave Version (revision SHA):
    0.13.0 rc5

  • Steps to reproduce:
    Try this once with Brave and once with Chrome

Process 1. set tabs to facebook, news.ycombinator.com, github.com/brave/browser-laptop, nytimes.com

Process 2. set 1 tab to nytimes.com

Process 3. set shields default to off, set tabs to facebook, news.ycombinator.com, github.com/brave/browser-laptop, nytimes.com

Process 4. set shields default to off, set 1 tab to nytimes.com

  • Actual result:

  • Expected result:

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?

  • Is this an issue in the currently released version?

  • Can this issue be consistently reproduced?

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:

@alexwykoff alexwykoff added this to the 0.13.0 milestone Jan 24, 2017
@bbondy
Copy link
Member

@bbondy bbondy commented Jan 25, 2017

Work done for this, I think we can close it:
6435c2e
494b944
c069eae
658dc43
63edc2e
4021756
fd811db

@bbondy bbondy closed this Jan 25, 2017
bbondy referenced this issue Jan 25, 2017
Auditors: @bridiver

This was causing sync IPC to happen very often because of the mouse move handler that uses it
bbondy referenced this issue Jan 25, 2017
Auditors: @bridiver
bbondy referenced this issue Jan 25, 2017
Auditors: @bridiver, @diracdeltas
bbondy referenced this issue Jan 25, 2017
Auditors: @bridiver
bbondy referenced this issue Jan 25, 2017
This gets called pretty frequently by chromium into electron even if it's not showing

Auditors: @bridiver
bbondy referenced this issue Jan 25, 2017
Auditors: @bsclifton
bbondy referenced this issue Jan 25, 2017
Accidentally broke some unit tests with my perf fixes

Auditors: @bsclifton
@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Jan 25, 2017

@bbondy Do we need QA for this issue specifically?

@bbondy
Copy link
Member

@bbondy bbondy commented Jan 26, 2017

perf fixes often have regressions but it'll be caught by generic testing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.