Skip to content
This repository has been archived by the owner. It is now read-only.

Connection info icon changes to site favicon #6841

Closed
srirambv opened this issue Jan 24, 2017 · 3 comments
Closed

Connection info icon changes to site favicon #6841

srirambv opened this issue Jan 24, 2017 · 3 comments

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Jan 24, 2017

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Connection info icon changes to site favicon

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.13.0
    rev 5bad531

  • Steps to reproduce:

    1. Enter any engine go key and press space
    2. Press backspace to remove the space and revert from the favicon to magnification icon
    3. Repeat the steps couple more times
    4. Now search with the same search engine go key
    5. Connection info icon is replaced by site favicon and remains same
  • Actual result:
    Connection info icon is replaced by site favicon

  • Expected result:
    Should retain connection info icon irrespective of how many page load are done on a site

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Not seen on stable release

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    connection_favicon

  • Any related issues:

@srirambv srirambv added this to the 0.13.0 milestone Jan 24, 2017
@bsclifton bsclifton assigned bsclifton and bbondy and unassigned bsclifton Jan 25, 2017
@bbondy bbondy closed this in 9e40411 Jan 25, 2017
bsclifton added a commit to darkdh/browser-laptop that referenced this issue Jan 25, 2017
Auditors: @bsclifton

Fix brave#6841
@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Jan 26, 2017

This should have been fixed right?

g

g

@luixxiul luixxiul added the needs-info label Jan 26, 2017
@luixxiul luixxiul reopened this Jan 26, 2017
@luixxiul luixxiul removed the needs-info label Jan 26, 2017
@bbondy
Copy link
Member

@bbondy bbondy commented Jan 26, 2017

it should be fixed yes

@srirambv
Copy link
Collaborator Author

@srirambv srirambv commented Jan 26, 2017

Additional QA steps

  1. Visit a site
  2. Enter engine go key to change the favicon
  3. Open a link in the site which is already opened, URL changes but the engine favicon is retained
bbondy added a commit that referenced this issue Jan 26, 2017
Auditors: @bsclifton

Fix #6841
@bbondy bbondy closed this in 23beee3 Jan 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.