Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSite-level ad blocking evasion (submitted by community) | expressen.se & aftonbladet.se #6917
Comments
|
Additional note from the same issue in the Community, related to these two sites on MacOS (in Windows, this is not an issue from what they've tested) Community URL: https://community.brave.com/t/websites-showing-ads-even-with-all-adblock-filters/908/6
|
|
Well i just wanted to say that it was the same problem on two computers one running OS X El Captitan and one running MacOS Sierra... I never tested on mavericks as it said in the description ;) Just wanted to point that out ;) By the way I am the same person that submitted the issue :D |
|
@Jacalz updated the issue above to reflect! Thanks! |
|
@Jacalz was kind enough to update on Community after reviewing the sites in question post: v0.13.1 https://community.brave.com/t/websites-showing-ads-even-with-all-adblock-filters/908/7
Given the above, I'm going to close this ad-related issue, and will open a separate one if it appears HTTPSe is not working as expected with the one site mentioned above. Thanks again @Jacalz - really glad we have you in the Community. :-) |
|
Re-opening the issue, as a pub has resurfaced with what appear to be wallpaper ads and interstitials. from @Jacalz via Community: https://community.brave.com/t/websites-showing-ads-even-with-all-adblock-filters/908/11
Domain: http://aftonbladet.se Additional feedback:
Screenshots provided: Domain: http://expressen.se/
The intermittency sounds like a campaign delivery pattern (some cases, ads may not be available to serve, so the issue is not reproduced in every instance). Checking on:
|
|
I've been able to reproduce, and determine the root cause (at least in the US). Expressen is using a 1p request system. Some 3p ads are getting thru, which I've been able to block the majority of using these rules:
This rule prevented their embedded ad video player from loading video ads: @Jacalz can you do me a favor and attempt the following, and let me know if you're able to reproduce. The problem is that half of these ads are 1st party, and not a threat, but some are. It's hard for me to gauge all the inventory being served as I'm in the US, so if you can check in your browser it should help.
||biowebb-data.s3.amazonaws.com^$script,image,domain=expressen.se
I'm going to include some of the dev tools steps in Community for you to try in case the above rules don't work. I'm going to check out the other domains as well, but we're getting close with Expressen.se from the looks of things, I have not been able to repro after the rules above were applied (so far) Thanks! |
|
Expressen.se has been investigated, tested and has a PR submitted in adblock-lists (with the help of @Jacalz - thanks!) Expressen.se adblock-lists issue: brave/adblock-lists#6 Checklist for this issue:
|
|
Update - found an additional item on aftonbladet.se that has been added to the issue and pr noted above in adblock-lists. Also discovered that the same ad implementation is in place on both domains, so appended the fliter rules to include both and am seeing the issue resovled on both domains. going to close this issue here, and will track any changes required in: brave/adblock-lists#6 |
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
Filed from a Community user.
Link to Community:
https://community.brave.com/t/websites-showing-ads-even-with-all-adblock-filters/908
"Two Swedish sites are still showing ads with adblock on, i have tested with all filters on the desktop version of brave and it still shows ads. There are no ads on the iOS version of brave and no ads when using chrome with adblock/adblock plus. Expressen is the worst, you can remove some ads by using swedish fanboy but not all..."
The two sites are:
expressen.se
http://www.aftonbladet.se/
Platform (Win7, 8, 10? macOS? Linux distro?):
Mac OS (OS X El Capitan) - likely in other OS's as well.
Brave Version (revision SHA):
0.13.0
Actual result:
Ads
Expected result:
Blocked ads
Will the steps above reproduce in a fresh profile? Tbd
If not what other info can be added?
Yes
Tbd
User experienced w/flash enabled and disabled in Brave. Going to investigate (Luke)