Skip to content
This repository has been archived by the owner. It is now read-only.

Add a history sub-menu to the hamburger (kabob) #6934

Closed
bradleyrichter opened this issue Jan 31, 2017 · 10 comments
Closed

Add a history sub-menu to the hamburger (kabob) #6934

bradleyrichter opened this issue Jan 31, 2017 · 10 comments

Comments

@bradleyrichter
Copy link
Contributor

@bradleyrichter bradleyrichter commented Jan 31, 2017

similar to chrome:

image

cc: @srirambv

@kumarrishav
Copy link
Contributor

@kumarrishav kumarrishav commented May 6, 2017

@bradleyrichter will Options in history submenu be same as what is there in History menu at tool bar (at top) ? Because, in chrome it's not exactly same. Can we have mocks for same?

@bradleyrichter
Copy link
Contributor Author

@bradleyrichter bradleyrichter commented May 8, 2017

@kumarrishav you are correct. The back-button history list only shows the history chain for that tab. The menus (in all cases) need to show the top N number of chronological history entries.

A mockup doesn't really show this well so I will dig up the other issue for main menus and link them.

@kumarrishav kumarrishav self-assigned this May 10, 2017
@kumarrishav
Copy link
Contributor

@kumarrishav kumarrishav commented May 15, 2017

Ok. Thanks @bradleyrichter

@kumarrishav
Copy link
Contributor

@kumarrishav kumarrishav commented May 16, 2017

currently i have added these submenu. Is it fine? or should we add more (recent closed) as it is in toolbar.
@bradleyrichter
screen shot 2017-05-16 at 7 14 12 pm

@bradleyrichter
Copy link
Contributor Author

@bradleyrichter bradleyrichter commented May 16, 2017

@kumarrishav This will be good. Keep in mind we will need to update it when the dynamic list is ready. (to show recently closed and recently visited history links)

kumarrishav added a commit to kumarrishav/browser-laptop that referenced this issue May 17, 2017
@alexwykoff alexwykoff modified the milestones: 1.0.0, Backlog Nov 1, 2017
@bsclifton bsclifton added priority/P5 and removed enhancement labels Nov 22, 2017
@bsclifton bsclifton modified the milestones: Triage Backlog, Backlog (Prioritized) Nov 22, 2017
@kjozwiak
Copy link
Member

@kjozwiak kjozwiak commented Nov 29, 2017

Pasting feedback that I added in #10807 (which is basically a duplicate of this):

We should look into ways of improving access to about:history for users on Windows. Currently, these are the only ways of accessing about:history which isn't really intuitive for the average user:

  • Pressing "ALT" and access History in the file menu
  • typing in about:history under the URL bar
  • Going into the Settings -> General and disable "Hide the menu bar by default"

Under macOS/Linux, the File Menu is usually visible the entire time so it's a lot easier to figure out where about:history can be access from.

I personally think we should add access to about:history in the following locations:

  • adding History under the Brave menu
  • adding History access under about:preferences#security (currently you can only clear)
@kjozwiak
Copy link
Member

@kjozwiak kjozwiak commented Mar 26, 2018

+1 from my brother. He was using Brave while he was online shopping and wanted to check his history for something he was previously looking at but closed earlier. He couldn't find a way to access History via the kabob so ended up searching for a solution via Google.

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Jun 28, 2018

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Jun 28, 2018

Btw this should be fixed in brave-core as built-in feature. @bradleyrichter still ok to keep the issue open?

@bsclifton
Copy link
Member

@bsclifton bsclifton commented Jun 28, 2018

@srirambv I think it's fair to say we won't be able to get to this with browser-laptop. Since it's fixed with Brave Core, let's close it out 😄 👍

@bsclifton bsclifton closed this Jun 28, 2018
@bsclifton bsclifton removed this from the Backlog (Prioritized) milestone Jun 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
7 participants
You can’t perform that action at this time.