Skip to content
This repository has been archived by the owner. It is now read-only.

123movies.is - 728x90 banner ad overlay w/Shields Up #7519

Closed
lukemulks opened this issue Mar 7, 2017 · 2 comments
Closed

123movies.is - 728x90 banner ad overlay w/Shields Up #7519

lukemulks opened this issue Mar 7, 2017 · 2 comments
Assignees

Comments

@lukemulks
Copy link
Collaborator

@lukemulks lukemulks commented Mar 7, 2017

  • Did you search for similar issues before submitting this one?
    Yes
  • Describe the issue you encountered:
    Reported from testers - ad overlay (active for 30s) when video playback is initialized.

URL: https://123movies.is/film/interstellar-1655/watching.html

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    1db81cb

  • Steps to reproduce:

    1. With Shields Up, go to https://123movies.is/film/interstellar-1655/watching.html
    2. Press play to initiate playback.
    3. Observe the ad banner video overlay (728px W x 90px H)
  • Actual result:
    brave-123movies-overlay-03072017

  • Expected result:
    Shields should block the display banner ad

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:

    1. Note: If the page is refreshed, there will be an alert that prompts the user to either resume playback from where the stream left off, or start from the beginning.
    2. The ad will not display when the video is resumed an earlier view.
    3. The ad will display if the video plays from the beginning of the clip.
  • Screenshot if needed:

Needs investigation.

Notes from first pass:

  • The ad appears to be loaded from within the JWPlayer configuration, most likely as a companion ad for a preroll/video ad.

  • However, it could be a player feature that allows for a companion ad to display for the content - would need to reference the JWPlayer documentation to see if this is a feature that has been built in.

  • Easy to filter by size in the DOM Elements view in Dev Tools by 728x90 to locate the display ad.

  • Need to determine which script is used from the player to call the display ad.

  • Need to determine if this is indeed a separate call from a video ad that is called, if the ad is called as a companion to the content, or if this is a standalone ad call made independently.

  • Screencap from the Elements view for reference:

brave-123movies-overlay-ad-indom-03072017

@lukemulks
Copy link
Collaborator Author

@lukemulks lukemulks commented Mar 7, 2017

UPDATE
Tested this rule in Windows 10, within about:adblock and it appears to resolve the issue and remove the banner.

Need to test from a clean profile.

Rule:
||123clouds.ru/*/custombanner.js^$script

If this passes - will submit PR to brave/adblock-lists

@lukemulks
Copy link
Collaborator Author

@lukemulks lukemulks commented Mar 7, 2017

Updated blocking rule that was tested.

Submitted an issue and PR in brave/adblock-lists

Going to close this issue, since we're now dealing with this in brave/adblock-lists

Issue: brave/adblock-lists#11
PR: brave/adblock-lists#12

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.