This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up123movies.is - 728x90 banner ad overlay w/Shields Up #7519
Closed
Labels
Comments
|
UPDATE Need to test from a clean profile. Rule: If this passes - will submit PR to |
|
Updated blocking rule that was tested. Submitted an issue and PR in brave/adblock-lists Going to close this issue, since we're now dealing with this in brave/adblock-lists Issue: brave/adblock-lists#11 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Yes
Reported from testers - ad overlay (active for 30s) when video playback is initialized.
URL: https://123movies.is/film/interstellar-1655/watching.html
Platform (Win7, 8, 10? macOS? Linux distro?):
All
Brave Version (revision SHA):
1db81cb
Steps to reproduce:
Actual result:

Expected result:
Shields should block the display banner ad
Will the steps above reproduce in a fresh profile? If not what other info can be added?
Yes
Is this an issue in the currently released version?
Yes
Can this issue be consistently reproduced?
Yes
Extra QA steps:
Screenshot if needed:
Needs investigation.
Notes from first pass:
The ad appears to be loaded from within the JWPlayer configuration, most likely as a companion ad for a preroll/video ad.
However, it could be a player feature that allows for a companion ad to display for the content - would need to reference the JWPlayer documentation to see if this is a feature that has been built in.
Easy to filter by size in the DOM Elements view in Dev Tools by
728x90to locate the display ad.Need to determine which script is used from the player to call the display ad.
Need to determine if this is indeed a separate call from a video ad that is called, if the ad is called as a companion to the content, or if this is a standalone ad call made independently.
Screencap from the Elements view for reference: