Skip to content
This repository has been archived by the owner. It is now read-only.

Provide right click context menu option for users to block 1st party Ads #7521

Closed
srirambv opened this Issue Mar 7, 2017 · 20 comments

Comments

Projects
None yet
@srirambv
Copy link
Collaborator

srirambv commented Mar 7, 2017

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Provide right click context menu option for users to block 1st party Ads

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    Brave 0.13.5
    rev 1db81cb

  • Steps to reproduce:

    1. Visit https://rediff.com
    2. Web page shows 1st party ads which are not blocked
    3. Users should have an option to block 1st party ads
  • Actual result:
    1st party ads are not blocked on sites

  • Expected result:
    User should have an option to block 1st party ads on websites along with the 3rd party ads that are blocked by default

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    Highlighted 1st party ads
    image

  • Any related issues:
    cc: @lukemulks

@srirambv srirambv added this to the 1.0.0 milestone Mar 7, 2017

@lukemulks

This comment has been minimized.

Copy link
Collaborator

lukemulks commented Mar 7, 2017

+1
Would also help with issues where paywall prompts block content until users whitelist the site w/their ad blocker.

Additional adblock support for blocking inline-scripts would be helpful here too.

@Jacalz

This comment has been minimized.

Copy link
Collaborator

Jacalz commented Mar 10, 2017

Here is an idea of what i think it should look like:
Just right clicking somewhere and pressing "block element". Then you can choose what element to block and it adds it as a filter in a "cosmetic filters" section in settings > shields > Manage Adblock Settings... 🦁 Just like in Ublock Origin 👍

@Liunkae

This comment has been minimized.

Copy link
Contributor

Liunkae commented Apr 11, 2017

+1 from #8210

@luixxiul

This comment has been minimized.

Copy link
Contributor

luixxiul commented Apr 24, 2017

can this be closed in favor of #344?

@srirambv

This comment has been minimized.

Copy link
Collaborator Author

srirambv commented Apr 24, 2017

#344 is only for cosmetic ads similar to the ones shown on Google after search. This is specifically for 1st party ads which are not blocked.

@Jacalz

This comment has been minimized.

Copy link
Collaborator

Jacalz commented Apr 27, 2017

@srirambv

This comment has been minimized.

Copy link
Collaborator Author

srirambv commented Aug 15, 2017

@eljuno

This comment has been minimized.

Copy link
Contributor

eljuno commented Sep 13, 2017

+1 from community https://community.brave.com/t/right-click-button-on-blocking-images-and-ads-idea/7547?u=eljuno

right click button on the mouse to block images and ads

@pongraczi

This comment has been minimized.

Copy link

pongraczi commented Sep 19, 2017

+100000000 thanks :)
maybe including some "trivial big players" individually, like this:

Disable 1st party ads:

  • Disable globally (everything)

Exceptions (enabled, even global disable active):

  • Google Search
  • Google Youtube
  • Google Mail
  • Facebook

Add your exception domains here:

[_____________________] [  add ]
[ myfavouriteads.com ]  [remove]
[ whateveris.org     ]  [remove]
[ *.specnews.com     ]  [remove]
@BraveSauce

This comment has been minimized.

Copy link

BraveSauce commented Sep 22, 2017

The title should change to "manually block content" and not "1st party ads".

On Chrome I use Ublock Origin to block all sort of annoying things that aren't "ads", tailoring the UI of my favorite websites to suit my needs.

Examples of content I block:

  • Resilient cookie reminders that will pop up each and every time, or other kinds of modern popups.

  • Annoying "Buy Premium/Upgrade" UI elements on freemium services that I don't wish to pay for.

@Jacalz

This comment has been minimized.

Copy link
Collaborator

Jacalz commented Sep 24, 2017

+1 on changing the title to something like "add option to right click to remove content"
I am totally agreeing with the user cases that @BraveSauce mentioned above 👍

@alexwykoff alexwykoff modified the milestones: 1.0.0, Backlog Nov 1, 2017

@cezaraugusto cezaraugusto modified the milestone: Triage Backlog Nov 8, 2017

@bsclifton bsclifton removed the enhancement label Nov 22, 2017

@candrews0

This comment has been minimized.

Copy link

candrews0 commented Dec 11, 2017

+1 this issue. It's a dealbreaker to my using Brave.

@dri94

This comment has been minimized.

Copy link

dri94 commented Dec 12, 2017

+1 on this issue

@steph643

This comment has been minimized.

Copy link

steph643 commented Dec 13, 2017

Very disappointed to see Google search ads not being blocked.

@PupoSDC

This comment has been minimized.

Copy link

PupoSDC commented Dec 24, 2017

Is this feature being worked on? Without this Brave is not really worth it...

@srirambv

This comment has been minimized.

Copy link
Collaborator Author

srirambv commented Feb 2, 2018

@xaliber

This comment has been minimized.

Copy link

xaliber commented May 10, 2018

+1

@srirambv

This comment has been minimized.

Copy link
Collaborator Author

srirambv commented Jun 6, 2018

+1 from @chris1000 via #14340

@StephenOwen07

This comment has been minimized.

Copy link

StephenOwen07 commented Jun 8, 2018

+1

@bsclifton

This comment has been minimized.

Copy link
Member

bsclifton commented Jul 10, 2018

Closing as a duplicate of #344

@Snuupy is working on this for Brave Core 😄 For more info, subscribe to brave/brave-browser#94

@bsclifton bsclifton closed this Jul 10, 2018

@bsclifton bsclifton added the duplicate label Jul 10, 2018

@bsclifton bsclifton removed this from the Triage Backlog milestone Jul 10, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.