Skip to content
This repository has been archived by the owner. It is now read-only.

Remove siteDetails.less #8235

Closed
luixxiul opened this issue Apr 11, 2017 · 0 comments
Closed

Remove siteDetails.less #8235

luixxiul opened this issue Apr 11, 2017 · 0 comments

Comments

@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Apr 11, 2017

Describe the issue you encountered: Remove siteDetails.less

This file is widely used on about pages, and some of them require another LESS file which imports siteDetails.less (X.less requires history.less, which imports siteDetails.less, for example). Creating the framework with Aphrodite reduces such cases and makes it easy to remove siteDetails.less completely.

So far these elements have been created into custom components:

  • <SectionTitle> (#8237)
  • <SiteDetailsPageHeader>
    • <SiteDetailsPageHeader actions> inside the Header (ref history.js and bookmarks.js)
  • <SiteDetailsPageContent>
  • TBA

Any related issues: #8165

@luixxiul luixxiul mentioned this issue Apr 11, 2017
3 of 4 tasks complete
@luixxiul luixxiul added this to the Backlog milestone Apr 12, 2017
@luixxiul luixxiul self-assigned this Apr 12, 2017
@luixxiul luixxiul removed this from the Backlog milestone Sep 11, 2017
@luixxiul luixxiul mentioned this issue Sep 11, 2017
4 of 8 tasks complete
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@luixxiul luixxiul removed their assignment Feb 15, 2018
@bsclifton bsclifton added the wontfix label May 10, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone May 10, 2018
@bsclifton bsclifton closed this May 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.