Skip to content
This repository has been archived by the owner. It is now read-only.

Not saving the ledger statement and closing browser causes background process to keep running #8466

Closed
srirambv opened this issue Apr 24, 2017 · 2 comments

Comments

@srirambv
Copy link
Collaborator

@srirambv srirambv commented Apr 24, 2017

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Not saving the ledger statement and closing browser causes background process to keep running. Subsequent browser launch fails due to the existing background process

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Windows 10 x64

  • Brave Version (revision SHA):
    Brave 0.15.0
    rev 8e63cc0

  • Steps to reproduce:

    1. Enable ledger payments and ensure you have payment history
    2. Click on any of the staments to open the statment in a new tab
    3. Click cancel in the file save prompt
    4. Close the browser window and start it from terminal
    5. Browser doesn't launch shows error message about GPU
    6. Open task manager, right click on the first background process and end task
    7. Save file prompt is opened, console shows Windows crash. Reloading...
    8. Have to kill other background process so that everything is cleared and only then can re-launch the browser
  • Actual result:
    Not saving the ledger statement and closing browser causes background process to keep running

  • Expected result:
    Process should be killed when the browser is quit.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:
    ledgercrash

  • Any related issues:
    cc: @bridiver @bbondy

@bsclifton
Copy link
Member

@bsclifton bsclifton commented May 2, 2017

@srirambv does this happen if you do file > save as on a regular page and then close the tab?

@bsclifton
Copy link
Member

@bsclifton bsclifton commented May 2, 2017

Closing as a dupe of #8629

@bsclifton bsclifton closed this May 2, 2017
@bsclifton bsclifton added the duplicate label May 2, 2017
@bsclifton bsclifton removed this from the 0.15.3 milestone May 2, 2017
@bsclifton bsclifton removed their assignment May 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.