This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSync code modal is not dismissed when trying to enable sync offline #8513
Labels
Comments
|
kicking to a later milestone since it is an edge case for the network to disconnect while the modal is open |
|
migrated to brave/sync#115 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Did you search for similar issues before submitting this one?
yes
Describe the issue you encountered:
Sync code modal is not dismissed when trying to enable sync offline
Platform (Win7, 8, 10? macOS? Linux distro?):
Windows x 64
Brave Version (revision SHA):
Brave 0.15.0
rev 6638b91
Steps to reproduce:
I have a existing codeto bring the modalSetup SyncActual result:
Sync code modal is not dismissed when trying to enable sync offline
Expected result:
Modal should not be shown
Will the steps above reproduce in a fresh profile? If not what other info can be added?
Yes
Is this an issue in the currently released version?
Not tested
Can this issue be consistently reproduced?
Yes
Extra QA steps:
1.
2.
3.
Screenshot if needed:

Any related issues:
Please change milestone if required