This repository has been archived by the owner. It is now read-only.
Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upURL bar input lag with 1000+ bookmarks #8643
Closed
Comments
|
Related to/duplicate of #7453 (Performance : urlbar response is slow when searching across many bookmarks). |
|
@Liunkae thanks! closing in favor of that |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Did you search for similar issues before submitting this one?
Yes
Describe the issue you encountered:
When the browser has many bookmarks, the URL bar lags between typing and displaying input.
Platform (Win7, 8, 10? macOS? Linux distro?):
MacOS
Brave Version (revision SHA):
master @ db26cac
Steps to reproduce:
0. Instrument
onKeyUp()inapp/renderer/components/navigation/urlBar.jsby adding console.log(${new Date().getTime()} onKeyUp >) at the beginning and console.log(${new Date().getTime()} onKeyUp <) at the end of the function.Actual result:
Latency is ~200ms.
Expected result:
<10ms (On a fresh profile, it takes ~3ms).
Will the steps above reproduce in a fresh profile? If not what other info can be added?
Requires 1000+ bookmarks.
Is this an issue in the currently released version?
Yes
Can this issue be consistently reproduced?
Yes