Skip to content
This repository has been archived by the owner. It is now read-only.

URL bar input lag with 1000+ bookmarks #8643

Closed
ayumi opened this issue May 3, 2017 · 2 comments
Closed

URL bar input lag with 1000+ bookmarks #8643

ayumi opened this issue May 3, 2017 · 2 comments

Comments

@ayumi
Copy link
Contributor

@ayumi ayumi commented May 3, 2017

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    When the browser has many bookmarks, the URL bar lags between typing and displaying input.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    MacOS

  • Brave Version (revision SHA):
    master @ db26cac

  • Steps to reproduce:
    0. Instrument onKeyUp() in app/renderer/components/navigation/urlBar.js by adding console.log(${new Date().getTime()} onKeyUp >) at the beginning and console.log(${new Date().getTime()} onKeyUp <) at the end of the function.

    1. Open Brave and import 1000+ bookmarks.
    2. Toggle browser debug console and open the JS console.
    3. Focus the URL bar and press the "A" key repeatedly.
    4. Observe browser debug JS console for onKeyUp() latency.
  • Actual result:
    Latency is ~200ms.

  • Expected result:
    <10ms (On a fresh profile, it takes ~3ms).

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Requires 1000+ bookmarks.

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes

@cndouglas
Copy link

@cndouglas cndouglas commented May 3, 2017

Related to/duplicate of #7453 (Performance : urlbar response is slow when searching across many bookmarks).

@ayumi
Copy link
Contributor Author

@ayumi ayumi commented May 3, 2017

@Liunkae thanks! closing in favor of that

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.