Skip to content
This repository has been archived by the owner. It is now read-only.

Make Brave portable ? #8691

Closed
crazy-max opened this issue May 4, 2017 · 7 comments
Closed

Make Brave portable ? #8691

crazy-max opened this issue May 4, 2017 · 7 comments
Labels

Comments

@crazy-max
Copy link

@crazy-max crazy-max commented May 4, 2017

Hi,

I've created a small wrapper named brave-portable but i was wondering if you had planned to do one day a portable version of Brave?

Thanks

@Jacalz
Copy link
Collaborator

@Jacalz Jacalz commented May 4, 2017

I will take a look at the wrapper today if I get some time over 👌

@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented May 4, 2017

@crazy-max I'm going try. Could I know how to use it? thanks!

@crazy-max
Copy link
Author

@crazy-max crazy-max commented May 4, 2017

@luixxiul All instructions are available in the README.md of brave-portable repository.

@luixxiul
Copy link
Contributor

@luixxiul luixxiul commented May 4, 2017

I see, I wanted to know how to build the binary from the source code.

Also is it OK to include the binary downloaded from Brave website, without including source code? (I'm just curious because I'm not familar with the licence stuff) CC @bbondy

@crazy-max
Copy link
Author

@crazy-max crazy-max commented May 4, 2017

Indeed i use the binaries from the official website :

Then i extract the setup and read the nupkg file instructions and make a self extraction and i copy the app-* folder and the execution stub to the root folder.

brave-portable.exe seek if the data folder located in %APPDATA%\brave exists and copy the folder in brave-portable\data and make / update the symlink between%APPDATA%\brave <=> brave-portable\data, that's it.

Then i package everything as 7z, zip and a simple InnoSetup like you can see in the latest release : https://github.com/crazy-max/brave-portable/releases/latest

But like you said it would be better to create the binaries from source first.

@msiyer
Copy link

@msiyer msiyer commented May 8, 2017

@crazy-max This is good. Compilation on Linux is straightforward. I have not had the time to compile on Windows. For people like us, we can have a git clone on our system which can be updated and built weekly using a cron job. A good solution for auto-update :), I think.

However, for mass consumption two problems still remain unaddressed:

  • The "executable signing" without which distributing the package may not be proper
  • The auto-update feature
@bsclifton
Copy link
Member

@bsclifton bsclifton commented May 9, 2017

I'm going to close this issue in favor of #2953

Let's continue the conversation there though 😄

@bsclifton bsclifton closed this May 9, 2017
@bsclifton bsclifton added the duplicate label May 9, 2017
diracdeltas added a commit that referenced this issue May 19, 2017
fix #8691

Test Plan:
1. https://jsfiddle.net/bkf50r8v/13/ should show no webgl fingerprint results with 'Fingerprinting Protection' enabled
2.  https://browserleaks.com/webgl with fingerprint protection on:  report hash should be '0C21A6FA2A9BD79DFF6E128FE55094B4', the image hash should be empty, all the fields under the triangle image should be empty
@diracdeltas diracdeltas mentioned this issue May 19, 2017
7 of 7 tasks complete
bsclifton added a commit that referenced this issue May 19, 2017
fix #8691

Test Plan:
1. https://jsfiddle.net/bkf50r8v/13/ should show no webgl fingerprint results with 'Fingerprinting Protection' enabled
2.  https://browserleaks.com/webgl with fingerprint protection on:  report hash should be '0C21A6FA2A9BD79DFF6E128FE55094B4', the image hash should be empty, all the fields under the triangle image should be empty
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
You can’t perform that action at this time.